Engineers-Life / EL2

https://www.curseforge.com/minecraft/modpacks/engineers-life-2
Other
3 stars 3 forks source link

Lack of foliage #84

Open Quilbij opened 3 years ago

Quilbij commented 3 years ago

Modpack Version: 1.03

Describe the bug There is a lack of foliage and every biome has the shape of plains

Log Files latest.log

Drakoflame commented 3 years ago

Me and a friend are having the same issue. We decided to re-make the world with the new update (because dungeon loot, new structures, etc), and were a bit shocked to see that all (Vanilla) biomes were completely devoid of any and all foliage, only modded biomes had trees and other decor

czbuendel commented 3 years ago

Install this mod: https://www.curseforge.com/minecraft/mc-mods/blame Load into the save that has the issue, run around for a bit. Explore a few new chunks. Then come back and upload the latest.log again.

D0CTOR-ZED commented 3 years ago

Also, if anyone encounters this in the current version in a world that wasn't created in a previous version, please provide the world seed and coordinates of an affected area. Thanks.

Drakoflame commented 3 years ago

This is me just trying to create a new world to generate the log to look. the game seized up and locked down and I had to task-manager close it

Clarification (for the next post) I didn't "Preview" the world, I just clicked create new world (cheats + bonus chest on)

latest.log

Drakoflame commented 3 years ago

Okay, so... I created two new worlds (using the "preview" function), and... instantly from the map view, I could see foliage generating. I kept the first one I made, and started a second one, it also had foliage. So I went to an existing world that I'd made (in this update of the pack) that didn't have foliage, and flew to the edge and... suddenly there were trees... I flew along the edge of the pre-generated area for a while, and there was foliage and everything else generating properly... Blame fixed it?!

Here's the log anyway (I appologize for the world name that I flew around in that didn't have foliage... I was having a bad start to the day and was pissed off at a bug with Immersive that only appears in multiplayer/non-host LAN servers.... for some weird reason): latest.log

czbuendel commented 3 years ago

This is me just trying to create a new world to generate the log to look. the game seized up and locked down and I had to task-manager close it

Clarification (for the next post) I didn't "Preview" the world, I just clicked create new world (cheats + bonus chest on)

latest.log

Well I can tell you there is an issue with your install location off this log. It being in a user folder is leading to some files being locked from being written to, which can be seen at the end with the errors it throws in respect to IE and IP. If you are on our discord I would look into the instructions on how to switch over to something like GDL or MultiMC and move your instances over. The instructions will indicate a place to install instances where your files won't end up locked and corrupted leading to errors.

Drakoflame commented 3 years ago

Well I can tell you there is an issue with your install location off this log. It being in a user folder is leading to some files being locked from being written to, which can be seen at the end with the errors it throws in respect to IE and IP. If you are on our discord I would look into the instructions on how to switch over to something like GDL or MultiMC and move your instances over. The instructions will indicate a place to install instances where your files won't end up locked and corrupted leading to errors.

I'm sure that'd solve 90% of my issues with other mods, I have a hard enough time getting the bloat ware they turned Curseforge into to work, and I'm sure it's easier with GDL or MMC, but the way I see it is I'd have to still use CF to download a pack and move it. If I need to move an install I'd just use the native launcher to move it's location and launch it through there, the only problem I forsee is updating Forge whenever that's needed, it's been a while since I've had to manually update to a newer forge version.

Install locations aside, was the log of any use to the issue? What about the second log? Any clue why vanilla decorations got Thanos'd?

czbuendel commented 3 years ago

GDL can download packs from Curseforge and allows full control over adding/removing mods and changing forge versions. You should give it a shot. I can post the instructions from our discord over here if you like.

I didn't see anything that I would expect to be causing issues from the log files. Last time vanilla gen was borked was because of a unregistered structure. I'm not seeing any indication of that now. I did see one notification from blame that I didn't like which is why I made a change to the CraftPresence files because it was injecting at a bad time.

czbuendel commented 3 years ago

You can uninstall blame (for some reason I think it fixes the issue strangely, but it causes a large amount of log spam.)

If you want then you can try adding this file in. Just remove the .txt from the end and let it overwrite the file of the same name in the config folder. craftpresence.properties.txt

Drakoflame commented 3 years ago

I'll give the craftpresence file a try later today, I've got a bit of stuff to do so I won't get a chance until later tonight for me. I'll also give GDL a try (I'm sure I can figure it out ;3), hopefully that'll fix some issues I have, and can get me away from the bloatware...

I've really been enjoying the modpack though! My only suggestion (and I know that this probably might not be the best place cus it's for a different issue > 3>) add some quests to help people understand how to bees. Me and my friend spent about an hour trying to get them started, but ended up having to cheat in some bees because we couldn't figure out how to get them started, hadn't found any nests anywhere (I think because decorations broke), and when we did figure them out, I spend another half hour or so trying to get the Ashy Mining Bee, but JEI and the bee-book gave no useful information on where it might spawn, and we ended up, once again, having to cheat some in. I also don't think that those types of bees, the "natrual spawning" ones don't use apiaries, which confused us when it came to bee breading. I thought it would be done in the boxes, but nope! vanilla breeding (which wasn't explained anywhere)

Drakoflame commented 3 years ago

Okay... 2 things, statement unrelated, statement related, and theory on the second statement

  1. GDL 100% better. Clean UI, Easy to manage profiles, one button start (instead of loading the laggy asf*** vanilla launcher), miniscule RAM impact (for those of us who are RAM tight).

  2. Wtf? I have trees again. Created a brand new world (using the method from the first log. Direct "create new world" without pre-loading) and it loaded just fine. Moved around a bit, immediately saw trees on theminimap, moved there, and now theres trees. Wtf?

    Theory: One of two things happened, either: A: Somehow, for some reason, Installing BLAME fixed it after removing the mod B: Mayhapse using the GDLauncher allowed it work properly? (To clarify, after re-installing the modpact for a second time, because I just c/p'd everything in the EL2 curse folder into the EL2 GD folder, and that broke things. Second time I just copied my Config/Mods/Saves/Resourcepack/Xaerosfolders/Options file over, loaded up everything just fine. So everything that could have caused the issue was transfered over.)

Thougths and Ideas on the possible reason for turning the worlds into a wasteland? Could there be some small issue that installing Blame somehow fixed, or is it potentially a pathing issue with a mod and everyone who used Curseforge (which isn't that hard to believe because the curseforge launcher is trashy at best, and doesn't work for a lot of things and frankly is annoying, packaged with bloatware, and unoptomized programing)

Drakoflame commented 3 years ago

and it Broke again... Methinks custom seeds are what break it... Seed I used: "GooseFlesh""

Followup: still broken, let minecraft pick it's own random seed

Drakoflame commented 3 years ago

latest.log Here's the log for the latest test (went back into a newer world, extracted seed: -2124476128396178225 )

czbuendel commented 3 years ago

Issue reported to BDB dev after extensive testing on discord. https://github.com/Xratedjunior/Better-Default-Biomes/issues/20 Currently removing BDB allows foliage to spawn again.

czbuendel commented 3 years ago

We encountered an issue similar to this that pointed to Supplementaries https://github.com/Engineers-Life/EL2/issues/53 It may have been this issue cropping up then.