search

Enricoza / EZCustomNavigation

Easy Custom Navigation Controller that allows popping view controllers with pan gesture from center too and UnPop them back in.
MIT License
23 stars 5 forks source link

Conflicts with UITableView delete gesture #5

Closed ReDetection closed 3 years ago

ReDetection commented 3 years ago

Hi. Pan-to-pop gesture seems to break swipe-to-delete gesture in UITableView. What is most funny it is still possible to swipe-to-delete but you have to put your finger very fast!

demo branch with table view is in my fork

Enricoza commented 3 years ago

Thank you for your report and for the demo branch @ReDetection, it was really helpful.

I'm working on this right now and will be releasing the fix asap.

Enricoza commented 3 years ago

Hi again @ReDetection, the v1.1.1 release should solve your problem. Thank you again for your time spent in opening the issue and creating the branch for me.

I'm going to close this issue but feel free to reopen or open a new one if something is still wrong.

PS: while looking into this I found another issue with the leadingSwipeActions of the table view for which I created a separate issue (#6) since it's going to need more attention.

ReDetection commented 3 years ago

Thanks you so much for the quick actions :)

Yeah, I tried to go with a fix too, but I stuck at the exact same issue, just with different gesture: if you leave cell in the middle state, when it has Delete button revealed, but not confirmed, you can't close it with a swipe to the right – pop to dismiss interferes. Anyway, I agree it is basically the same as #6 so it makes sense to continue there

Enricoza commented 3 years ago

Hi again @ReDetection, From my tests it seemed to work properly (even if I'm not entirely sure why)

Did you have this problem every time or just in some cases? Did you try my sample from the master branch? (Maybe in your app this is having some other kind of conflicts) Or maybe It happens only on some iOS versions that I haven't tested...

Enricoza commented 3 years ago

I can confirm that, oddly enough, this works perfectly on iOS 12 while on iOS 14 it has the slight disadvantage that you can't swipe the delete button out (but you can still tap anywhere to dismiss it). I guess it's still better than before so we can move the discussion on the other thread.