EntilZha / PyFunctional

Python library for creating data pipelines with chain functional programming
http://pyfunctional.pedro.ai
MIT License
2.41k stars 132 forks source link

sequence.right_join doc example code #106

Closed BebeSparkelSparkel closed 4 years ago

BebeSparkelSparkel commented 7 years ago

Right and left join have the same example code in their docs.

>>> seq([('a', 1), ('b', 2)]).join([('a', 3), ('c', 4)])
        [('a', (1, 3)), ('b', (2, None)]

I think it should be

>>> seq([('a', 1), ('b', 2)]).join([('a', 3), ('c', 4)])
        [('a', (1, 3)), ('c', (None, 4)]
BebeSparkelSparkel commented 7 years ago

Changed this in PR: Cleanup #107

EntilZha commented 7 years ago

Nice catch, if you separate this out into its own little change I can merge independently of the rest of the stuff

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.