Hi @bouthilx ! This PR tries to fix #1083 . However, I don't know how to test it in CI. CI currently tests normal installation, but this issue seems related to a corner case, and I don't know how to reproduce it in CI.
So, this PR just checks both <sys.prefix> then <sys.prefix>/local to find dashboard build parent folder (named orion-dashboard).
On regular installations (e.g. in CI tests), checking <sys.prefix> is enough. But it seems data are installed in <sys.prefix>/local on Jupyter installations. I don't know why there's this difference.
Checklist
Tests
[ ] I added corresponding tests for bug fixes and new features. If possible, the tests fail without the changes
[ ] All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)
Documentation
[ ] I have updated the relevant documentation related to my changes
Description
Hi @bouthilx ! This PR tries to fix #1083 . However, I don't know how to test it in CI. CI currently tests normal installation, but this issue seems related to a corner case, and I don't know how to reproduce it in CI.
Changes
t seems that, depending on installation, additional files may be installed in
<sys.prefix>/local
instead of just<sys.prefix>
. More info: https://stackoverflow.com/questions/14211575/any-python-function-to-get-data-files-root-directory#comment99087548_14211600So, this PR just checks both
<sys.prefix>
then<sys.prefix>/local
to find dashboard build parent folder (namedorion-dashboard
).On regular installations (e.g. in CI tests), checking
<sys.prefix>
is enough. But it seems data are installed in<sys.prefix>/local
on Jupyter installations. I don't know why there's this difference.Checklist
Tests
$ tox -e py38
; replace38
by your Python version if necessary)Documentation
Quality
$ tox -e lint
)