Epistimio / orion

Asynchronous Distributed Hyperparameter Optimization.
https://orion.readthedocs.io
Other
283 stars 52 forks source link

Fix detection of dashboard build files in installed packages. #1084

Closed notoraptor closed 1 year ago

notoraptor commented 1 year ago

Description

Hi @bouthilx ! This PR tries to fix #1083 . However, I don't know how to test it in CI. CI currently tests normal installation, but this issue seems related to a corner case, and I don't know how to reproduce it in CI.

Changes

t seems that, depending on installation, additional files may be installed in <sys.prefix>/local instead of just <sys.prefix>. More info: https://stackoverflow.com/questions/14211575/any-python-function-to-get-data-files-root-directory#comment99087548_14211600

So, this PR just checks both <sys.prefix> then <sys.prefix>/local to find dashboard build parent folder (named orion-dashboard).

On regular installations (e.g. in CI tests), checking <sys.prefix> is enough. But it seems data are installed in <sys.prefix>/local on Jupyter installations. I don't know why there's this difference.

Checklist

Tests

Documentation

Quality

notoraptor commented 1 year ago

@bouthilx it seems to have worked, including conda-build !