Epsidon / Observatoire

Observatoire de la santé des francophones
2 stars 0 forks source link

image marker to show which tab is selected #72

Closed gvjourdan closed 10 years ago

gvjourdan commented 10 years ago

The little triangle beneath the selected tab is missing. Currently, we don't know which tab is selected

Seyed-M-Mirtaheri commented 10 years ago

Hi, I meant to talk to you about this one (the missed call yesterday). It is harder than I originally taught to put the rectangle below the selected tab. Is there any other way we could signify the selected tab?

gvjourdan commented 10 years ago

Really ? I thought it would be a walk in the park for you:-) I am not sure what our option ares. Changing the color ?

Seyed-M-Mirtaheri commented 10 years ago

Thank you for the vote of confidence :)

I do not want to bore you with the details, but if you are interested, the problem is that bootstrap uses a complicated relative positioning for the navigational bar that confuses jquery. This makes it difficult for me to get the exact position of the tab to put the rectangle beneath it.

I think Ava came up with an idea that may work.

gvjourdan commented 10 years ago

I think the idea of Ava to put some color around the selected tab might work, but we will need to get the designer to send the necessary images. In addition, in the new update:

ghost commented 10 years ago

all issues are fixed. I set a selected tab to be shifted down to show more difference. It would be great to have designer data/images for this.

gvjourdan commented 10 years ago

Thanks. I think we want to keep the tabs unshifted for now, simply using the color to show the selection, until we get the designer's design