[Feature request] Grey palette

Erallie / colored-candy

A cute lil' theme based on your accent color.

MIT License

4 stars 1 forks source link

[Feature request] Grey palette #6

Open ElsaTam opened 2 weeks ago

ElsaTam commented 2 weeks ago

By using the accent color to style the theme, the hue value for grey colors (red = green = blue) is always 0 (red). This is therefore no possible to create a grey theme.

Would it be possible to add this feature in the style settings? I can think of two ideas, but they are just suggestions:

a toggle that just set any saturation to 0 (except maybe for some text you want to see accented, such as links) --> when enabled, this will make the "Background-to-text contrast" only change the lightness
separate the slider "Background-to-text contrast" into two sliders saturation/lighntess and let the possibility to slide down the saturation to 0

Erallie commented 2 weeks ago

@ElsaTam I was previously considering this!

Perhaps I can make a toggle in the settings for a "Grey mode", where the background and everything that isn't accented is grey?

But then I'd have to consider whether to make the accented stuff their original hue instead of the altered hue... 🤔

ElsaTam commented 2 weeks ago

@Erallie Basically, that would just be the default color palette from Obsidian that is all grey. Except for accented colors. But yeah, I think that would be it, if you want to make this feature. As I said, it was more a thought in case this is something that you want because I saw a possible conflict. But that's like giving the possibility to remove half of the signature of your theme.

Erallie commented 2 weeks ago

But that's like giving the possibility to remove half of the signature of your theme.

@ElsaTam It is certainly removing half of the theme signature lol. Changing the accent colors back to default would require a little bit more work than just using the altered accent colors, since I would need to define more variables for it.

Maybe I can allow an option for it, but make the accent colors still have the same saturation and lightness as the new accent colors...

ElsaTam commented 2 weeks ago

@Erallie Sorry for the delay! Yes, I think if you alow the grey palette, best is to keep how you compute all the colors nonetheless. It's more a fix for when user is targeting a color with saturation 0 that ends up being red. But your theme make more calculations that you should keep, I think. Because they are so cool.