search

EricGuo5513 / momask-codes

Official implementation of "MoMask: Generative Masked Modeling of 3D Human Motions (CVPR2024)"
https://ericguo5513.github.io/momask/
MIT License
689 stars 56 forks source link

Gumbel Softmax in Quantizer #41

Closed exitudio closed 2 months ago

exitudio commented 2 months ago

Thank you for your amazing work. I just want to make sure I understand the code correctly. The Gumbel Sampling is not necessary here, the Argmin version (line 76) will be exactly the same result, correct?

https://github.com/EricGuo5513/momask-codes/blob/0421a2b8367483ec2a140153037999d9f167a8e6/models/vq/quantizer.py#L76-L78

Murrol commented 2 months ago

Hi, we set the sampling temperature here: https://github.com/EricGuo5513/momask-codes/blob/0421a2b8367483ec2a140153037999d9f167a8e6/models/vq/model.py#L72 So the Gumbel Sampling results would be different from Argmin version. They are from argmin w/ noise.

exitudio commented 2 months ago

Thank you for clarification.