Closed dbukki closed 1 week ago
For some reason the diff contains several changes from unrelated PRs, which were already merged. This makes quite hard to review this PR, and the changes should be rebased to master
.
For some reason the diff contains several changes from unrelated PRs, which were already merged. This makes quite hard to review this PR, and the changes should be rebased to
master
.
Any insights on this @dbukki? Could you refactor this PR to master
? I would love to merge this, but it is quite hard to review it like this.
Any insights on this @dbukki? Could you refactor this PR to
master
? I would love to merge this, but it is quite hard to review it like this.
Sorry for not noticing your comment earlier. My branches must have been out of sync by the time I rebased this branch onto my latest version of master to add the parallelization of bumpy road. The funky diff behavior is probably a result of that. I synced my fork, the diff seems alright now.
Fixes #733
Added parallelization support to the C++ metrics parser plugin:
getFilterPathsQuery
, we can now perform the same check as whatcc::util::isRootedUnderAnyOf
used to do, but on the ODB-side. This is good because:filePath
members can now be removed from views that only needed them for this purpose. This further reduces the amount of data needed to be transferred per record as well.parallelCalcMetric
method of the metrics parser now serves as the backbone of all parallel computations.Further considerations: