EricssonResearch / cerbero

OpenWebRTC cerbero fork
GNU Lesser General Public License v2.1
19 stars 58 forks source link

openwebrtc.recipe: Fix libopenwebrtc_bridge_jni.so (Android) #10

Closed nirbheek closed 9 years ago

nirbheek commented 9 years ago

libopenwebrtc_bridge_jni.so that it depends on libopenwebrtc_jni.so instead of bundling it statically. This allows openwebrtc_bridge.jar to depend on openwebrtc.jar.

Change requested by rugvip

Rugvip commented 9 years ago

As discused on IRC, this does make openwebrtc_bridge.so depend on the GStreamer etc. But any dependency that is common between both openwebrtc.so and openwebrtc_bridge.so will be included in openwebrtc_bridge.so, but it should really just depend on openwebrtc.so for those dependencies.

The problem with this except for wasted space is the type registry in GLib, which is completely broken.

nirbheek commented 9 years ago

@Rugvip libopenwebrtc_bridge_jni.so now doesn't include a second copy of glib (or any other library, such as libiconv, etc).

Rugvip commented 9 years ago

Yup, seems like it's working now :smiley: I'm running into this problem though: EricssonResearch/openwebrtc#177 :neutral_face:

nirbheek commented 9 years ago

Let's push this PR then?

Rugvip commented 9 years ago

merged