Errorname / prisma-multi-tenant

🧭 Use Prisma as a multi-tenant provider for your application
MIT License
396 stars 45 forks source link

Space in path name throws error on generation #22

Closed Xaedblade closed 4 years ago

Xaedblade commented 4 years ago

This is an issue for windows computers. I've run into this several times. my fix was to change my project folder name on my home pc. But my work laptop uses my name as the user with a space... so can't fix. i.e C:\Users\firstname lastname\ will throw an error because of the space in the path.

error message: Are you sure of your inputs? Yes

Updating your schema.prisma file...

Generating prisma clients for both management and tenants... { Error: Command failed: C:\Users\C* V*****\Desktop\warehouse 3\node_modules.bin/prisma2 generate 'C:\Users\C***' is not recognized as an internal or external command, operable program or batch file.

at ChildProcess.exithandler (child_process.js:294:12) at ChildProcess.emit (events.js:198:13) at maybeClose (internal/child_process.js:982:16) at Process.ChildProcess._handle.onexit (internal/child_process.js:259:5) killed: false, code: 1, signal: null, cmd: 'C:\Users\C* V**\Desktop\warehouse 3\node_modules\.bin/prisma2 generate ' }

Errorname commented 4 years ago

Thanks for raising this issue 🙏

I can reproduce this, I'll fix this in the next release

Xaedblade commented 4 years ago

Thank you! That would be great 🥇

Xaedblade commented 4 years ago

@Errorname I can fix this if you like? I know where the issue is.

Errorname commented 4 years ago

Thank for offering, but I already wrote a fix. 🙂 I'm finishing the documentation for the new release and I'll publish it by the end of the day or tomorrow

Errorname commented 4 years ago

The latest release alpha22 should now work with folder having spaces. (See breaking changes in release notes, before installing alpha22)

Thanks again for filing this issue 🙏

Xaedblade commented 4 years ago

Thanks!