search

Eskibear / node-jdk-utils

A collection of Java related utils.
MIT License
10 stars 5 forks source link

add support for jbang #18

Open maxandersen opened 1 month ago

maxandersen commented 1 month ago

done similar to #6 to add support for detecting jbang installed jdks.

should help vscode-java :)

Eskibear commented 1 month ago

@testforstephen @jdneo @rgrunber

Please help to take a look.

jdneo commented 1 month ago

Not related with this PR, but an idea about supporting such cases.

Since the implementation is whitelist based, we can consider allowing the utility to accept a list of additional location for jdk searching. Then adding those additional paths when using it at redhat.java extension side.

Then we can customize the behavior and no need to release a new version when more candidates are added.

maxandersen commented 1 month ago

fixed the issues.

maxandersen commented 1 month ago

Not related with this PR, but an idea about supporting such cases.

Since the implementation is whitelist based, we can consider allowing the utility to accept a list of additional location for jdk searching. Then adding those additional paths when using it at redhat.java extension side.

Then we can customize the behavior and no need to release a new version when more candidates are added.

it would be nice to be able to add additional roots; still nice to have sdkman, asdf, jbang, etc. available out-of-box without requiring redhat vscode setup.