search

Eskibear / node-jdk-utils

A collection of Java related utils.
MIT License
10 stars 5 forks source link

Use asdf data directory instead of asdf install directory #8

Closed bytzo closed 2 years ago

bytzo commented 2 years ago

This pull request fixes an issue where Java runtimes from non-git asdf installations would not be discovered.

Depending on the asdf installation method, the ASDF_DIR environment variable sometimes points to a directory that does not contain asdf installs. ASDF_DIR represents the location of asdf itself, rather than the location of asdf installs. For example, ASDF_DIR is set to /opt/homebrew/opt/asdf/libexec/ on my machine because asdf is installed through Homebrew.

Instead, the ASDF_DATA_DIR environment variable can be used, enabling the discovery of Java runtimes from non-git asdf installations.

Eskibear commented 2 years ago

BTW, what's your usage of this npm package, and do you need a new release shipping this fix right now?

bytzo commented 2 years ago

Thanks for the review! I use this package through the VS Code Java Extension. A new release isn't super urgent to me since the extension allows you to manually configure Java runtimes, however one would still be much appreciated.

Eskibear commented 2 years ago

shipped with v0.4.4