search

Especializa / nativescript-ng-shadow

Angular directive to apply shadows to native elements according to the elevation level guidelines of material design specification
Apache License 2.0
54 stars 38 forks source link

Adding NGC compiler support for AOT and Web pack compatibility. #14

Closed JoshDSommer closed 6 years ago

JoshDSommer commented 6 years ago

@especializa-user and @berardo thank you so much for this wonderful Angular Directive. I've taken the liberty to upgrade the project to compile using Angular NGC compiler instead of typescripts compiler. This should be enough to allow webpack and AOT compatibility. However, I'm not familiar with your build scripts so it's quite possible I missed something. This should help resolve these issues: https://github.com/Especializa/nativescript-ng-shadow/issues/6

thaoula commented 6 years ago

Hi Guys,

Any ideas when and if this will this be merged?

Regards, Tarek

ManuelSch commented 6 years ago

Please, this has been open for almost a month. Anyone care to merge? The lacking webpack and aot support makes the plugin virtually impossible to use in production.

ManuelSch commented 6 years ago

How do I get access to the latest changes in the master branch (including this merge)?

The latest package version in the npm registry is still 2.1.0 (from December 2017) and including the Github repo directly as a dependecy in my package.json (as suggested here) results in an error: Could not install from "Especializa\nativescript-ng-shadow" as it does not contain a package.json file.

"dependencies": { ... "nativescript-ng-shadow": "Especializa/nativescript-ng-shadow", ... },

lambourn commented 6 years ago

@ManuelSch yes, I'm wondering the same. @berardo would be cool if you could publish the latest version (including this PR) to npmjs.org - as mentioned by @ManuelSch the GitHub repository does not contain a package.json so we cannot just install from the master.

ManuelSch commented 6 years ago

@lambourn If you need it real quick, just download the repo as a zip file, take the content of the src folder and use it to overwrite the files in your /node_modules/nativescript-ng-shadow folder. Works as a short-term solution, but obviously these changes will be gone as soon as you run npm install the next time.

lambourn commented 6 years ago

@ManuelSch sure. I cloned it locally outside node_modules and set my dependency to file:// location instead. Still, would be great if the maintainers could push a new package to npmjs.org

lambourn commented 6 years ago

@especializa-user and @berardo - would be cool if you could publish the latest version including this PR to npmjs.org. Thanks a lot!

FranciZ commented 6 years ago

It works with --env.aot --env.uglify flags now but it doesn't without --env.aot and just --env.uglify and or without any env flags for that matter for me? Is this expected behaviour?

RoyiNamir commented 6 years ago

Can please you Bump the version and update NPM ?

bzaruk commented 6 years ago

Hi @berardo - any chance you bump the version? :)

RadouaneRoufid commented 6 years ago

Please publish the version to npm.

captainhaddock29 commented 6 years ago

Can please you Bump the version and update NPM ?

JoshDSommer commented 6 years ago

I've forked and repackage this directive in the standard Angular Package format and published it to NPM here: https://www.npmjs.com/package/nativescript-ngx-shadow. @especializa-user if wish just let me know and I can open a PR with the changes included. I just wanted to get this out there since the directive is so amazing and lots for people are clamoring to use it.

github for the fork is here: https://github.com/TheOriginalJosh/nativescript-ngx-shadow