EspressoSystems / hotshot-query-service

Generic query service for HotShot applications
https://espressosystems.github.io/hotshot-query-service/
GNU General Public License v3.0
5 stars 1 forks source link

Replace explorer prefix search with exact match for block and transaction hash #722

Closed imabdulbasit closed 3 weeks ago

imabdulbasit commented 3 weeks ago

addresses https://github.com/EspressoSystems/espresso-block-explorer/issues/148

This PR:

Ayiga commented 3 weeks ago

@Ayiga can you confirm this will work with the block explorer?

I think this should be fine in terms of functionality at the moment. There is a slight change in the input requirements that may cause problems with the current version of the Block Explorer. That being the requirement of the input to be a TaggedBase64. Though I do think that this is a good change, it does mean that the unchanged search request will start returning 4xx errors where it before didn't.

But this is likely alright, as we'll want to change the Block Explorer's search behavior regardless so that it isn't submitting these requests when they don't conform to the TaggedBase64 requirements.

Ayiga commented 3 weeks ago

Just tested this. The 4xx errors aren't affecting the current block explorer in any meaningful way. So this should be relatively safe. Though, gain we'd want to update the logic in the block explorer to not send partial TaggedBase64 search terms.