Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
295 stars 76 forks source link

Enhancement: Radio Group - Add color property #477

Closed asangma closed 4 years ago

asangma commented 4 years ago

Similar to button, it could be useful to have the color property on RadioGroup.

I see cases where there might be a radio group in a panel near a "primary" and "secondary" button set, e.g. Done Cancel, and the RadioGroup starts to look really similar.

UNTZ UNTZ UNTZ

macandcheese commented 4 years ago

Yeah, can see that use case.

Would using the "appearance" nomenclature from calcite-button work here (solid, outline) vs "color"? Got any mockups of what you might want an alternative appearance to look like 👀 ?

asangma commented 4 years ago

I'm cool with whatever nomenclature you prefer. But I was thinking kinna lik-a-dis. Screen Shot 2020-04-16 at 8 48 56 AM

Note, I'm using a gray that's more like 6a6a6a. The 404040 that button color="dark" uses seems too strong in this context. I think even the 6a6a6a is a bit strong for the border in this case. But I'm open.

macandcheese commented 4 years ago

@bstifle any thoughts here on a new Radio Button style?

bstifle commented 4 years ago

Not a fan of the gray tbh. if not interacting with it readily, its weird which one is selected since there are only 2. @asangma @macandcheese

bstifle commented 4 years ago

image

maybe something more like this? (even if the highlight were gray) (would prefer blue but ¯_(ツ)_/¯ )

https://www.esri.com/en-us/arcgis/products/arcgis-desktop/buy

i know this is a little divergent.... but idk man the gray/white on off isnt my fav

paulcpederson commented 4 years ago

We use that blue outline style a lot in ArcGIS Online. I like that a lot better than the gray. My vote is @bstifle 's above take

paulcpederson commented 4 years ago

Can use the same prop nomenclature as button as well so it's an easy and consistent api

macandcheese commented 4 years ago

Yep, appearance="solid/outline" would match button, default to solid.

asangma commented 4 years ago

Thanks y'all. I'll try it out.

asangma commented 4 years ago

image

Y'all are so good! Ship it!

mitc7862 commented 4 years ago

Looks good. Like the blue outline version.

julio8a commented 4 years ago

Looks really good!