Closed asangma closed 4 years ago
Yeah, can see that use case.
Would using the "appearance" nomenclature from calcite-button
work here (solid, outline) vs "color"? Got any mockups of what you might want an alternative appearance to look like 👀 ?
I'm cool with whatever nomenclature you prefer. But I was thinking kinna lik-a-dis.
Note, I'm using a gray that's more like 6a6a6a
. The 404040
that button color="dark"
uses seems too strong in this context. I think even the 6a6a6a
is a bit strong for the border in this case. But I'm open.
@bstifle any thoughts here on a new Radio Button style?
Not a fan of the gray tbh. if not interacting with it readily, its weird which one is selected since there are only 2. @asangma @macandcheese
maybe something more like this? (even if the highlight were gray) (would prefer blue but ¯_(ツ)_/¯ )
https://www.esri.com/en-us/arcgis/products/arcgis-desktop/buy
i know this is a little divergent.... but idk man the gray/white on off isnt my fav
We use that blue outline style a lot in ArcGIS Online. I like that a lot better than the gray. My vote is @bstifle 's above take
Can use the same prop nomenclature as button as well so it's an easy and consistent api
Yep, appearance="solid/outline"
would match button, default to solid.
Thanks y'all. I'll try it out.
Y'all are so good! Ship it!
Looks good. Like the blue outline version.
Looks really good!
Similar to button, it could be useful to have the color property on RadioGroup.
I see cases where there might be a radio group in a panel near a "primary" and "secondary" button set, e.g.
Done
Cancel
, and the RadioGroup starts to look really similar.UNTZ UNTZ UNTZ