search

Esri / crowdsource-polling

Provides a means for citizens to provide feedback to their governments
Apache License 2.0
20 stars 15 forks source link

Revise attachment dialog on side panel #187

Closed ScottOppmann closed 7 years ago

ScottOppmann commented 7 years ago

Implement more subtle feedback when an attachment is uploaded. Could implement something similar to the Crowdsource Reporter. Maybe just color change - green when successful, red when failed.

screen shot 2017-08-18 at 4 16 52 pm

MikeTschudi commented 7 years ago

Crowdsource Reporter uses feedback along the lines of image image image

Crowdsource Polling uses the light blue "info" color shown in the screenshot above for success (Crowdsource Reporter uses the "success" color) and the "danger" color that Crowdsource Polling uses for failures. (Color scheme is from the bootstrap library that both apps use.)

These messages are useful because color alone can be hard to see; e.g., here's what the "success" color looks like under three types of color blindness: image

@ScottOppmann, may I have more details of your request, please.

ScottOppmann commented 7 years ago

@MikeTschudi - I did not think about the challenges with the color but do think we should be consistent. Ie. Green if successful, red if not. It also looks like the font used in Polling is different than Reporter and would suggest we be consistent. So, I would suggest we amend Polling's info message so it matches the color and style of Reporter. Make sense?

MikeTschudi commented 7 years ago

Sounds clear; thanks!

allisonmuise commented 7 years ago

@MikeTschudi Is this ready for me to test? At a quick glance, it appears to be working...

allisonmuise commented 7 years ago

verified on devext