Esri / distance-direction-addin-dotnet

Add-in provides the ability to easily and quickly create geodesy lines, circles, ellipses and range rings.
Apache License 2.0
17 stars 22 forks source link

ArcGIS Pro crashes when you add a point with Distance and Direction on Pro 2.1 #651

Closed BobBooth closed 5 years ago

BobBooth commented 5 years ago

Open ArcGIS Pro (2.1) with latest (3.4.0.226) MT addin (or DD 4.1.1.48) with a new map. Open Distance and direction. Click the Map point tool (on Line or Circle tabs). Click on the map. Pro crashes.

Does not affect Circle or Ellipse tabs. Does not affect Pro 2.3 Does not affect Pro 2.2

BobBooth commented 5 years ago

@csmoore @dfoll @kgonzago @lfunkhouser - crash with DD on Pro 2.1

csmoore commented 5 years ago

I see the problem (that was introduced in this PR/line with some odd behavior on 2.1 - map point clicks don't seem to have same SR as the map) and will PR in a bit

dfoll commented 5 years ago

confirming now, so i can understand when we look at it to see the fix

csmoore commented 5 years ago

Addressed in PR #652

dfoll commented 5 years ago

Solutions\DefenseSolutions\DistanceAndDirection\Testing\csm-651-crash-on-map-point-tool-2-1\28 to test fix

dfoll commented 5 years ago

with Solutions\DefenseSolutions\DistanceAndDirection\Testing\csm-651-crash-on-map-point-tool-2-1\28 i'm not seeing the above behavior on 2.1 (but i did not repro for myself before installing this build). @BobBooth what are you finding?

dfoll commented 5 years ago

i went back and installed the old version and observed the crash, then installed testing...\28 and confirmed it is fixed... merging and building to dev

dfoll commented 5 years ago

Solutions\DefenseSolutions\DistanceAndDirection\March2019\Dev\49 is built to test before we

  1. ask for another version to be signed
  2. build into MT
dfoll commented 5 years ago

Dev\49 looks good. going to rebuild MT then try to get another version of DD and MT signed

BobBooth commented 5 years ago

@dfoll Dev\49 worked for me.

dfoll commented 5 years ago

Solutions\DefenseSolutions\MilitaryToolsForArcGIS\March2019\Dev\227 exists now to test the MT build

BobBooth commented 5 years ago

@dfoll MT Dev 227 works.

dfoll commented 5 years ago

MT 227 and DD 49 both work for me

dfoll commented 5 years ago

going to send both off to ask to have them signed again