search

Esri / esri-leaflet

A lightweight set of tools for working with ArcGIS services in Leaflet. :rocket:
https://developers.arcgis.com/esri-leaflet/
Apache License 2.0
1.61k stars 799 forks source link

update npm release process #1317

Closed gavinr closed 2 years ago

gavinr commented 2 years ago

In today's builds, siteData.json is still not getting published to npm.

This is because we have an issue with our release process: right now, release.sh generates the dist files on line 8 when npm test runs. Then later when npm publish runs, npm prepare runs as part of that, which runs npm run build, re-building the dist files. I think this is unnecessary and causing siteData.json to not be included in the npm release.

So, this PR changes it so that when publishing, do not use "prepare" script to re-build the dist files, just use the files that are there from earlier in release.sh when it ran npm test.

patrickarlt commented 2 years ago

LGTM! Does siteData.json also get included in the GitHub release?

gavinr commented 2 years ago

Yes, it is in the GitHub release.