Esri / military-features-data

Source data for Esri defense and intelligence feature templates. This data is used to create features and derived data products using military symbology.
Apache License 2.0
46 stars 32 forks source link

BUG-000090508 Some identity and status options for military symbols in the ArcGIS Runtime SDK for Qt API are not honored #218

Closed ghost closed 6 years ago

ghost commented 8 years ago

This Issues is an issue in the symbol dictionary and should be logged here.

It is already listed:

BUG-000090508 - Some identity and status options for military symbols in the ArcGIS Runtime SDK for Qt API are not honored.

LDF 1/31/2018: Updated with additional information from the issue:

  1. Download the attached "MilitarySymbols.zip" file. Unzip this file. Note the file contains a Qt Project and the MIL-STD-2525C document.
  2. Open the project in Qt Creator. Scroll down to line 66. This section of code adds multiple SIC codes to a string list. Each of these 5 SIC codes have an identity parameter (the second letter in the SIC code) this is not working.
  3. Open the MIL-STD-25-25C document. Scroll down to pages 15 and 16. Observe the possible options for identies are:

Pending (P), Unknown (U), Friend (F), Netural (N), Hostile (H), Assumed Friend (A), Suspect (S), Exercise Pending (G), Exercise Unknown (W), Exercise Friend (D), Exercise Neutral (L), Exercise Assumed Friend (M), Joker (J), Faker (K).

  1. However the runtime Qt API does not honor the following identity options:

Pending (P), Assumed Friend (A), Suspect (S), Exercise Pending (G), Exercise Assumed Friend (M).

  1. Run the application. Compare the observe that the bottom row of features do not conform to the standard described in the MIL-STD-2525C document.
  2. Look at lines 78 - 89. These 6 SIC codes have different status parameters (the fourth letter in the SIC code).
  3. Scroll down to line 51 in the MIL-STD-2525C document. Observe the possible options for statuses:

Anticipated (A), Present (P), Fully Capable (C), Damaged (D). Destroyed (X), Full to Capacity (F).

  1. However the API does not honor the Anticipated (A) status.
  2. Run the application. Compare the second symbol in the top row. Observe that while the Anticipated status requires the frame to have a dotted outline this symbol has a solid outline. This makes the Anticipated symbol look just like the Present symbol.

Data: \sf_filestore\PRD\Attachments\Defects\BUG-000090508

csmoore commented 6 years ago

Note: this issue concerns the planning/dashed frames which were not supported in the app6b renderer

topowright-zz commented 6 years ago

We need to understand how we will address this issue. @csmoore has shared a few ideas based on how we built/support 2525-B

lfunkhouser commented 6 years ago

@csmoore This issue was reported for 2525C, not APP-6(B).

csmoore commented 6 years ago

@lfunkhouser - my bad - this should be working with 2525C and ready to retest now using Runtime 100.0+.

To test, I recommend using the symbol export app

lfunkhouser commented 6 years ago

Thanks, @csmoore Good to hear! I'll remove the epic designation from this issue. @topowright, @ACueva @dfoll Please estimate the remaining effort and log a detailed issue for APP-6(B).

topowright-zz commented 6 years ago

I am taking a closer look at this now.

topowright-zz commented 6 years ago

With @csmoore help I now understand how to test these symbols, but I need to find the symbols that we know are not drawing according to this issue.

topowright-zz commented 6 years ago

Looking at the customer information provided here is a better breakdown of what they have found as not supported. These examples are directly from pages 15,16, and 51. I have been able to draw a few correctly and a few not correctly.

// Page 15 and 16 in MIL-STD-2525C document explains the identities SPGPUCD-------- //P - Pending, yellow, dotted line //Not Working

SAGPUCD-------- //A - Assumed Friend, blue, dotted line //Not Working

SSGPUCD-------- //S - Suspect, red, dotted line //Not Working

SGGPUCD-------- //G - Exercise Pending, yellow, dotted line, black X //Not Working

SMGPUCD-------- //M - Exercise Assumed Friend, blue, dotted line, black X //Not Working

//Page 51 in MIL-STD-2525C document explains the statuses SFGPUCD-------- // P Present - No modifier

SFGAUCD-------- // A Anticipated/Planned - Dotted Line //Not Working

SFGCUCD-------- // C Present/Fully Capable - Green Rectangle

SFGDUCD-------- // D Present/Damaged - Yellow Rectangle

SFGXUCD-------- // X Present/Destroyed - Red Rectangle

SFGFUCD-------- // F Present/Full To Capacity - Cyan Rectangle

topowright-zz commented 6 years ago

I will move forward with showing these examples for each code given. I will be able to finish this work tomorrow. I wanted to share what I have found thus far.

topowright-zz commented 6 years ago

I have captured the need for APP6 in the following issue asking for a bit of help from team members to add additional information if needed in the following issue:

https://github.com/Esri/military-features-data/issues/295

csmoore commented 6 years ago

@topowright - those ones listed above seem to be drawing OK for me - attached is the export script I used to test and screenshot of the output.

bug_test-mil2525c-BUG-000090508.bat.txt

image

BobBooth commented 6 years ago

Comment moved to 295.

topowright-zz commented 6 years ago

These symbols are supported: image

topowright-zz commented 6 years ago

image

topowright-zz commented 6 years ago

Based on the two images above we are drawing everything correctly except the color of the cyan rectangle is really: blue: RGB(0, 0, 255)

It should be: cyan RGB(44, 177, 238) This is from page 19 image @lfunkhouser @csmoore is this something that we should worry about?

topowright-zz commented 6 years ago

symbolexamples.zip Here are the output symbols that were generated.

topowright-zz commented 6 years ago

@csmoore looking further into this issue I am finding that the blue box draws differently in ArcGIS Pro and Runtime. I have made sure that the runtime app has the same stylx file as the one I used in Pro.

The image on the right is based on the test Runtime app: image

I am not sure exactly where to go from here.

csmoore commented 6 years ago

@topowright - it looks like you are comparing 2 different styles/standards - left looks like app6b (which I don't think has these status modifiers) and right looks like something else - 2525 ?

Also - those 2525 icons are provided to us - so any color discrepancies might need to be addressed in source data provided by gov't - ex: https://github.com/Esri/military-features-data/blob/dev/military-symbology-styles/utils-and-source-data/svg/OCA/010052.svg

topowright-zz commented 6 years ago

@lfunkhouser can you give us a path forward.

topowright-zz commented 6 years ago

@csmoore looking at the issue based on your last comment it seems like the blue symbol shows up in ArcGIS Pro as well. You were correct that I was looking at the APP6B style. Here is the screen shot using MSE:

image

topowright-zz commented 6 years ago

This issue can be closed, but it did span other questions that will be addressed here: https://github.com/Esri/joint-military-symbology-xml/issues/484

@lfunkhouser are you okay with us closing this issue?