Esri / military-symbology

A user-focused add-in for searching, creating, and editing military symbols in ArcGIS Pro.
Apache License 2.0
38 stars 11 forks source link

Create APP6B Schema + lpkx #362

Closed lfunkhouser closed 5 years ago

lfunkhouser commented 5 years ago

Needed for Pro 2.4 implementation of APP6B

Tasks:

BobBooth commented 5 years ago

PR with the files: https://github.com/Esri/military-symbology/pull/366

dfoll commented 5 years ago

Moved to Impeded because we do not have a dictionary renderer that supports drawing attributes from this schema

csmoore commented 5 years ago

Added tasks for adding attributes: civilian: Boolean, countrylabel - string to original issue

csmoore commented 5 years ago

The attribute-based military overlay GDB has been generated from the source data in this dev branch - and available here if needed

image

The updated attribute-based APP-6(B) dictionary renderer is now available in the Pro 2.4 daily install and the layer package is ready to be created for this (working on that next).

csmoore commented 5 years ago

Creating the layers and templates is complete, just need to test the packaging/unpackaging.

image

The only issue I have noticed so far is that a couple of the Tactical Graphics names are not very descriptive (about 8 names) - but these names were right from the Tactical Graphics SIDC Table B-IX - not sure if we need to correct these (UPDATE: these names were fixed in https://github.com/Esri/military-symbology/commit/8d53937d157acc2f31e3d7ea2c836f092174a07c) :

image

csmoore commented 5 years ago

The attribute-based app6b layer package was added to here. This also includes the corrections to the unclear Control Measure names noted above. This should complete the dev work and this should be ready to verify (Note: requires latest/daily Pro 2.4).

csmoore commented 5 years ago

I noticed a few lpkx layers were missing metadata - so fixing that now (UPDATE: fixed).

dfoll commented 5 years ago

doc for this issue should done with #373