Add alpha-alpha, alphanumeric, and numeric labels (with label origin options) to GRGs created from MGRS grids

Esri / solutions-grg-widget

A GRG (Gridded Reference Graphic) is a grid overlay used for a common reference point in many situations - from cordon and search operations to security for presidential inaugurations.

Apache License 2.0

3 stars 3 forks source link

Add alpha-alpha, alphanumeric, and numeric labels (with label origin options) to GRGs created from MGRS grids #49

Closed Dbarnes1 closed 6 years ago

Dbarnes1 commented 7 years ago

After the September release, we should add the labeling functionality that we currently have for non-MGRS GRG labels to the GRGs created from MGRS (both point and area)

Label types

[x] alpha-alpha
[x] alphanumeric
[x] numeric

Label start position

[x] lower-left
[x] upper-left
[x] lower-right
[x] upper-right

This will have to handle the zipper/grid zone issues discussed here: https://github.com/ArcGIS/solutions-grg-widget/issues/44

topowright-zz commented 6 years ago

@adgiles has been able to make headway on the feature based on polygons.

adgiles commented 6 years ago

Addressed in PR https://github.com/Esri/solutions-grg-widget/pull/125

dfoll commented 6 years ago

[x] verified fix is good in WAB 2.6 DE (from the repo)
[x] updated checklist test - in the test catalog repo (Removed G-QA Create (Checklist))
[x] Need someone to verify the checklist test is good (then remove G-QA Verify (Checklist))
[x] Need someone to verify the doc is good (has not been published yet, to ensure this does not inadvertently go out with the wrong release) (then remove G- QC (Doc)) done by @ACueva
[x] updated workflow documentation (removed note that said these were not available when creating by reference system
[x] added a note to the release item to include this functionality in the "what's new"/"release notes"

dfoll commented 6 years ago

@adgiles label direction still not available when defining a grid by reference system? (wasn't part of this issue, just making sure this was intentional, if we need that we can open another issue later)

adgiles commented 6 years ago

@dfoll I didn't see label direction as part of this issue, I just implemented what was described by Dan above.

dfoll commented 6 years ago

@adgiles perfect....i was just making sure i wasn't missing anything on my end.

topowright-zz commented 6 years ago

I have verified that the checklist allows a tester to understand what they are supposed to be testing if they have intimate knowledge of the widget.

topowright-zz commented 6 years ago

I need to understand the workflow better between CMS and our website. I am not sure where these doc updates are. I have spent time reviewing create-grg-from-area-using-widget, but I am not sure where the doc updates are located in this topic.

topowright-zz commented 6 years ago

Also, @lfunkhouser these topics are written differently than the rest of our solutions. I like the idea of grouping larger topics into one general topic. Just FYI

dfoll commented 6 years ago

updated documentation is in cms until it gets published as part of the release process