Esri / solutions-grg-widget

A GRG (Gridded Reference Graphic) is a grid overlay used for a common reference point in many situations - from cordon and search operations to security for presidential inaugurations.
Apache License 2.0
3 stars 3 forks source link

Reference System Label Settings (which may be MGRS) #61

Open joebayles opened 6 years ago

joebayles commented 6 years ago

Update

Original Issue

Grid Zone Designator to be off by default with the option to turn the GZD on under the label settings

Instead of creating dialogs to turn on or off things like the Grid Zone Designator and the 100Km Grid Square Identifier, should we just reuse the coordinate notation dialog from the Coordinate Conversion Tool? It has the same look and feel as other widgets, and gives full customization to the user. See below for examples:

Coordinate Conversion Dialog: image

Options Dialog: image

joebayles commented 6 years ago

Allowing someone to selectively remove GZDs and GSIDs, but select that grid size, would create a situation where they create a label without any text. In subsequent releases, it may be prudent to program the widget to catch that.

adgiles commented 6 years ago

Addressed in this commit: https://github.com/ArcGIS/solutions-grg-widget/commit/53248a941f42c819a1e2fe4611687546d66574a5

untitled

joebayles commented 6 years ago

Working great! A few comments:

  1. I think this should also be exposed in the configuration dialog, under the Reference System tab.
  2. I would change the tooltip text below:

    Z: Grid Zone Designation (GZD) S: 100,000-meter grid square designator X: X Coordinate (Easting) Y: Y Coordinate (Northing)

    Example: Z-S-X-Y 15S-WC-80817-51205

... to:

Z: Grid Zone Designator (GZD)
S: 100,000-meter Grid Square Identification (GSID)
X: Easting (X Coordinate)
Y: Northing (Y Coordinate)
Examples:
ZSXY is 15SWC8081751205
ZS X,Y is 15SWC 80817,51205
adgiles commented 6 years ago

@joebayles how do you see the configuration working for this? Do you think we need three input boxes for each of the following formats: Grid Zone, 100,000 and then 10,000 and below?

adgiles commented 6 years ago

Any thoughts, anyone?

elinz commented 6 years ago

@adgiles @joebayles If this control is going to be placed on the configuration dialog then I see this as being the same single input textbox that is on the tool dialog; I don't see a reason why we would change the user experience just because we may add it to the configuration dialog.

adgiles commented 6 years ago

@elinz the content in the text box changes depending on what grid scale you are using:

joebayles commented 6 years ago

@adgiles, sorry I was out. I think for the first release, using the existing label format dialog would be sufficient. We can explore breaking them out in subsequent releases.

adgiles commented 6 years ago

This should have been taken out of this sprint last week

joebayles commented 6 years ago

Well, the tooltip is updated. Can you not expose that dialog on the configuration pane? If not, then yeah, let's move it to after next.

adgiles commented 6 years ago

It was removed from this sprint as the PEs said they would not have time to test any implementation of the configuration settings

joebayles commented 6 years ago

It's still in the sprint. I'll remove it.

FYI @ArcGIS/arcgis-defense-solutions