search

Esri / storymap-series

The Story Map Series lets you present a series of maps via tabs, numbered bullets, or a side accordion.
Apache License 2.0
63 stars 59 forks source link

Pop-up are not positioned properly #5

Closed glazou closed 9 years ago

glazou commented 9 years ago

Reported on GeoNet https://geonet.esri.com/thread/127300

jonoogle commented 9 years ago

I think the problem is in setPopupPosition (Mainstage.js ) around line 981. It bases the position on the current position of the infoWindow and not where the new popup will be.

glazou commented 9 years ago

Thanks! Not sure how I missed this but yes looks like that placement is done too early... I remember struggling developing this, I think I need to find another way to get the event from the API, this can't be just delayed to accommodate Feature Service query that may take a while.

jonoogle commented 9 years ago

That's what I figured and I played around with it a bit but didn't find an easy solution, but I don't have a good handle on all of the things happening in the code. thanks for looking at it.

glazou commented 9 years ago

That's often tricky but thanks for looking! There must be a way, stay tuned :)

jonoogle commented 9 years ago

I think actually this bug was fixed. I had found a solution but then looked at the code in git, and around line 640 of MainStage.js you commented out the "selection-change" event and used "aspect-after" which seems to work fine.

glazou commented 9 years ago

This was indeed fixed in a previous release, just that the app was not up-to-date.