Compat. Issue with Handcrafted and ModernFix [Fabric 1.21]

[pewblaze]

Hi, i really love the mod but got a small compat issue with the mod handcrafted. The painting from handcrafted is one single item, but has painting variants.

The problem is that the are visible in the "complete collection" & also can be found as variants (like the wandering trader).

Can i somehow disable them or hide them or anything? Maybe with a datapack? ^^" Like that mod XY isnt used.

Thanks!

[Estecka]

Can i somehow disable them or hide them or anything? Maybe with a datapack? ^^" Like that mod XY isnt used.

To quickly answer this question in particular, you can add paintings to the tag #invarpaint:exclusive. Variants in this tag will no longer be implicitely included in any loot table or trade pool.

However, this will not prevent the paintings from appearing in the "Complete Collection" item. This variant of the stockbook was only added as a debug tool, so I don't plan on making an exception for it. (I had also considered moving it to the Operator tab instead.)

[Estecka]

For the greater problem of making the mods fully compatible, this will be difficult as Handcrafted puts its own spin on the vanilla variant system.

Handcrafted still seems to be mostly relying on the vanilla system, so the simplest solution would be to just ignore the Fancy Painting item, and actually use the regular painting versions you've found so far. The only thing lost in process should be the 3d frame, but I could use some input from the other mod's developpers on how their system work.

One thing that's still bothering me is that in your screenshots, their painting variants appear as missing texture. I wasn't able to reproduce this; on my end, the correct placeholder texture is used. I'll need to know more about your mod setup and resource packs to figure out what happens.

[pewblaze]

Thanks! Ill try that. Its okay if they are disabled in my modpack :) So that solution works for me - ill try that later.

Im working on a modpack atm & got a bunch of mods + resource packs. I started the game without the resource packs & it still is with the texture error. But i can zip the modrinth modpack for you if thats alright. Or heres the mod list: (nor sure how to share it in the best way ^^) https://gist.github.com/pewblaze/7d32ed4e1e5cd1e5d0563b8b9ec3a3bc

https://www.dropbox.com/scl/fi/pzw2xsk5wwcr6m5kpahhb/1.21-Fabric-Blazecraft-1.0.0.mrpack?rlkey=7yrcohk811ocdqgc38e757lne&st=wlo0gvtc&dl=0

[Estecka]

That is a lot of mods to go through. The best thing you could do is some binary searching; try disabling as many mod as possible, until you can't reproduce the bug anymore. The least mods are required to reproduce, the better.

(Honnestly, I've never installed a modpack before, and I don't think MultiMC supports them.)

[Estecka]

I had a suspicion that Dynamic Assets Generator might be involved, but it doesn't do anything on its own. Do you know which mods in your pack depend on it ? That could be a good lead.

[pewblaze]

Yes its https://modrinth.com/mod/excavated_variants

I will try to find the culprit, maybe i can do that. I disabled them for now with a tag so thats fine for me :)

[pewblaze]

Oh ive got it. Its ModernFix https://modrinth.com/mod/modernfix

& theres a opimization that causes the texture bug: https://github.com/embeddedt/ModernFix/wiki/Dynamic-Resources-FAQ

[Estecka]

ModernFix just pushed a new patch. You'll be able to use the Dynamic Resources optimization with modded paintings. (https://github.com/embeddedt/ModernFix/issues/433)