search

EthoML / VAME

Variational Animal Motion Embedding - A tool for time series embedding and clustering
https://ethoml.github.io/VAME/
GNU General Public License v3.0
16 stars 2 forks source link

Try Python 3.10 #73

Open bendichter opened 3 months ago

bendichter commented 3 months ago
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

see 2 files with indirect coverage changes

bendichter commented 3 months ago

@vinicvaz I'm attempting to expand our environment to include Python 3.10 so this can be easily run on Google Colab I also think it's good to have this be able to run on more than a single version of Python if possible. The tests are failing but it looks like it might be just due to the way the tests were written. It looks like you may be using a newer feature of patch. Would it be possible to write these files without using patch? Maybe storing the config as a tempfile would be more straightforward?

bendichter commented 3 months ago

@vinicvaz I've also modified the CI so that the tests run on PRs. This is the standard way to do it so you know if tests fail before you merge ;-)

vinicvaz commented 3 months ago

@bendichter if the problem is just the tests we can find a way to replace what are conflictant. I don't think removing the patch mocks to a config file is a good options,, there are some tests we need to override some settings or arguments on the fly to make. I don't know why but my github is not showing the entire logs in the actions (as shown in the image below) so I didn't see what exactly is failing. Can you see the entire log?

image

vinicvaz commented 3 months ago

@bendichter about the CI, great, thanks for fixing this. If I'm not wrong we were running the tests only from dev because of the github 2000 minutes / month limit for free accounts. When we were actively commiting on multiple branches we could potentially reach this limit since the tests can take some time to run and we have 3 OS to test.

bendichter commented 3 months ago

@vinicvaz the 2,000 minute limit is for private repositories. There is no limit for public repositories (source)

GitHub Actions usage is free for standard GitHub-hosted runners in public repositories, and for self-hosted runners. For private repositories, each GitHub account receives a certain amount of free minutes and storage for use with GitHub-hosted runners, depending on the account's plan.

bendichter commented 3 months ago

Also, I emailed you the console output because I think it's too long to post here

luiztauffer commented 2 weeks ago

the reason why Python 3.10 was requested is because that is the default version in Google Colab. But this is about to change: https://github.com/googlecolab/colabtools/issues/4935

I suggest we keep supporting Python >= 3.11