EttusResearch / uhd

The USRP™ Hardware Driver Repository
http://uhd.ettus.com
Other
1k stars 666 forks source link

RFNoC "addsub" Block YAML Parameter #809

Open sumdudelr opened 1 week ago

sumdudelr commented 1 week ago

Issue Description

The included "addsub" block's YAML definition contains a string parameter. The quotation marks do not carry forward to the generated rfnoc_image_core.sv. Building FPGA image will fail.

Setup Details

Expected Behavior

FPGA image builds successfully

Actual Behaviour

Synthesis fails with:

ERROR: [Synth 8-1031] Verilog is not declared [repo/icores/build-x310_rfnoc_image_core/rfnoc_image_core.sv:1591]

Steps to reproduce the problem

Just add an "addsub" block to your RFNoC image.

Additional Information

Can be fixed by adding a few lines to addsub.yml to use hdl_parameters as is done in OOT example gain.yml.