Italic text's background is incorrect

Eugeny / tabby

A terminal for a more modern age

https://tabby.sh

MIT License

57.06k stars 3.3k forks source link

Italic text's background is incorrect #7719

Open pseudocc opened 1 year ago

pseudocc commented 1 year ago

I was migrating from Vim to NeoVim, and picked a color-scheme which uses 'italic' style, and I found that the background is not transparent. I investigated this about an hour, and the root cause should be from xterm.js, but I am not sure if tabby is calling xterm correctly, since I cannot run yarn to install deps successfully and debug further.

Version: 1.0.187 Platform: Linux x64 5.15.0-56-generic Plugins: none Frontend: xterm-webgl

Screenshot from 2023-01-02 19-32-36

reikrom commented 4 months ago

Version: 1.0.197 Platform: [ "Linux x64 6.7.5-200.fc39.x86_64", "macOS x64 23.3.0" ] Plugins: workspace-manager Frontend: xterm-webgl

color theme: rose pine

color theme: 3024 Day

quick test: echo -e "\e[3mitalic\e[0m"

edit: switching to xterm-canvas and reloading Tabby seems to fix the issue.

HCY-ASLEEP commented 3 months ago

I met the same problem.

xxChinaski commented 2 weeks ago

Also have the same problem. But not only with ITALICS but also with "underline". (just opened the same file in alacritty). Version: 1.0.207 Platform: Linux x86_64 6.9.3-3-MANJARO Plugins: None Frontend: xterm-webgl

xxChinaski commented 2 weeks ago

Find the way to fix this. Just disable GPU acceleration