search

European-XFEL / h5glance

Explore HDF5 files in terminal & HTML views
BSD 3-Clause "New" or "Revised" License
65 stars 7 forks source link

Add copylink to links #25

Closed t20100 closed 4 years ago

t20100 commented 4 years ago

Small PR to propose adding a copylink to links.

Downside is that copied path for external link as filename//path is not directly usable. Alternative would be to put a copylink for both filename and path but it is more cluttered.

takluyver commented 4 years ago

Thanks!

My thinking generally has been that we don't need a special thing for text that you can already select and copy - it's there for the internal paths because they're broken up by the tree structure, so it's otherwise not easy to copy them. But I guess that's not particularly a reason not to have them.

t20100 commented 4 years ago

Yes, I agree, but I couldn't select and copy it (currently on macos with both safari and firefox).

takluyver commented 4 years ago

That's bizarre, I see it too. I'm trying to work out what could stop it being selectable

t20100 commented 4 years ago

Great thanks! Then this PR would indeed not be needed.

takluyver commented 4 years ago

Turns out this is what happens if I copy and paste CSS that contains user-select: none ;-)