Eurotermbank / Federated-Network-Toolkit-deployment

Other
2 stars 1 forks source link

No warning when a term identical to what already exists in a term list is added #12

Open mariask2 opened 3 years ago

mariask2 commented 3 years ago

There is no warning when a term identical to what already exists in a collection is added (when using the tool's interface for adding new terms). It is therefore possible to add two identical terms to the same collection without being aware of it.

Within the field of terminology, I've heard that there in some circumstances is a rule that for terminology to be sound, there shouldn't exist two identical terms, except if you explicitly point that out by giving them some kind of homograph reference. So it might be the case that this situation should be handled somehow. Also from a user perspective, you might want to know if you add a term that is identical to one that already exists in the collection.

This is the relevant part from the exported TBX from when I added new terms:


<termEntry id="tgl-217">
  <langSet xml:lang="en">
    <ntig>
      <termGrp>
        <term>Added entry</term>
      </termGrp>
      <admin type="status">approved</admin>
    </ntig>
  </langSet>
  <descrip type="subjectField">Politics</descrip>
</termEntry><termEntry id="tgl-218">
  <langSet xml:lang="en">
    <ntig>
      <termGrp>
        <term>Added entry</term>
      </termGrp>
      <admin type="status">approved</admin>
    </ntig>
  </langSet>
  <descrip type="subjectField">Politics</descrip>
</termEntry>
mariask2 commented 3 years ago

I posed a question to our mailing list to get some more feedback on this issue report to get some input from those not using GitHub. I posed the question as follows: What should happen if two term entries with identical terms are added to the same collection? In the example attached (two computer.png), two term entries with the term "computer" is added. In the Swedish national term bank, two identical terms in the same collection need to have a number attached. I.e., they would be "computer (1)" and "computer (2)". two computer

And received the following answer from Marie: That would be the case in a standardised term entry as well. It is for example very handy to use different term entry numbers (mandatory in standards) when it comes to separating homographs like in the example below:

number_example_marie

So in summary: a) When there are two identical terms in two separate term entries in the term collection, there needs to be a way for the user to separate them (e.g. that they have numbers attached to them that are different.) b) When the user manually adds a term identical to one that already exists, there should be a warning, to make sure that the user wants to add a new term entry with an identical term, and that it is not done by mistake.