search

EventideSystems / tool_for_systemic_change

GNU Affero General Public License v3.0
6 stars 0 forks source link

Get "Something went wrong error' for creation or selection of SDG Alignment Cards #775

Closed emily-humphreys closed 2 years ago

emily-humphreys commented 2 years ago

Describe the bug

Getting 'Something went wrong error' for both of these actions:

  1. When you Select 'Create SDGs Alignment Card' at end of the preview screen
  2. When you select an SDG Alignment Card from the list of the page

To Reproduce

Steps to reproduce the behavior: Account: TAD OZ Minerals Cards 407 / 408 https://app.wickedlab.com.au/sustainable_development_goal_alignment_cards/408

  1. Go to SDGs Alignment Cards
  2. Click on either SDGs Alignment Card
  3. Add info - follow bread crumb
  4. At preview screen select "Create"
  5. See error_

It is then creating them - but when you go to select them you get the error again

  1. Go to SDGs Alignment Cards
  2. Click on either SDGs Card listed
  3. Get error

Expected behavior

Should take you to the card

Screenshots

Screen Shot 2022-06-28 at 9 02 11 pm
ferrisoxide commented 2 years ago

DEV NOTE

This issue appears to be caused by SDGs containing initiatives without any organisations. Patch fix is just to warn if the user accesses the Thematic SDGs Network Map tab:

image

Longer term, we may want to disable that tab completely (and the Ecosystem Map) if they can't be rendered due to data issues (with a tooltip to explain why). Or some other appropriate solution.

Strike that. Better to render the map, but provide "No results" in drop down list of organisations.

ferrisoxide commented 2 years ago

NOTES TO QA

Steps to reproduce the issue:

  1. Create a new SDGs card, but do not associate any organisations with the default initiative.
  2. After saving, visit the list of SDGs cards
  3. Select the newly created card
  4. Visit the "Thematic SDGs Network Map" tab

Expected behaviour

The system should display a warning message, indicating why it can't generate the map.

The map will render, but the dropdown list of organisations indicates "no results".

Other tabs should work as before.

ferrisoxide commented 2 years ago

@emily-humphreys @SishaMish This is on staging and ready for QA. Have modified the behaviour (see amended NOTES TO QA above).

SishaMish commented 2 years ago

@ferrisoxide @emily-humphreys

QA'd and ready for production

ferrisoxide commented 2 years ago

Deployed to production. Closing.

ferrisoxide commented 2 years ago

DEV NOTES

Verified that SDGs card id 407 can now be accessed:

image
emily-humphreys commented 2 years ago

Thank you guys :)

On Wed, Jun 29, 2022 at 3:11 PM Tom Tuddenham @.***> wrote:

DEV NOTES

Verified that SDGs card id 407 can now be accessed:

[image: image] https://user-images.githubusercontent.com/6169/176360014-ce5a35bb-631b-4f63-8e7c-a82f0f674bdd.png

— Reply to this email directly, view it on GitHub https://github.com/ferrisoxide/wicked_software/issues/775#issuecomment-1169555846, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFVZOVSRCOJ3KIH7PAPC4TVRPOXXANCNFSM52B3LLZQ . You are receiving this because you were mentioned.Message ID: @.***>