Closed japilo closed 1 year ago
All modified lines are covered by tests :white_check_mark:
Comparison is base (
5aedb1c
) 90.21% compared to head (5211984
) 90.28%.:exclamation: Current head 5211984 differs from pull request most recent head 9be1b10. Consider uploading reports for the commit 9be1b10 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks @japilo for this. I don't think we should remove variables from a dataset. Could you please change it so that we recode the problematic variables as something like X_orig and Y_orig? Also, can you please add an appropriate unit test? Thanks!
I was having problems with a sf data object that already had its coordinates stashed in X, Y columns, so I added some code to check if the correct coordinates are already there as X, Y. If they are, the sf coordinates are not bound. If there are X and Y columns that don't match the coordinates, they are replaced with a warning.