breakage with upcoming version of tune

[simonpcouch]

Hey yall! Simon here, a maintainer on tidymodels.

The upcoming release of the tune package contains changes that have caused some breakages in your package. Here's what we see:

Newly broken

• checking examples ... ERROR

  Running examples in ‘tidysdm-Ex.R’ failed
  The error most likely occurred in:
  
  > ### Name: autoplot.simple_ensemble
  > ### Title: Plot the results of a simple ensemble
  > ### Aliases: autoplot.simple_ensemble
  > 
  > ### ** Examples
  > 
  > # we use the two_class_example from `workflowsets`
  ...
  2.26658549056941, 1.55070434710052, 2.61077822145814, 0.976627263268401,
  1.86637107997978, 0.675410781588896, 1.27855056115075, 1.39156478397907,
  1.03940782815086, 1.69628613309882, 1.32644435902627, 3.31674522338439,
  2.79572399056405, 3.37417921047442, 1.14087715338524, 1.56584397770581,
  1.74205067903299, 2.71615811524246, 1.9713369592 [... truncated]
  Warning: Unknown or uninitialised column: `metric`.
  Error in if (!any(mtr_info$metric == metric)) { : 
    missing value where TRUE/FALSE needed
  Calls: %>% ... add_member.tune_results -> <Anonymous> -> check_metric_in_tune_results
  Execution halted

• checking tests ... ERROR

    Running ‘spelling.R’
    Running ‘testthat.R’
  Running the tests in ‘tests/testthat.R’ failed.
  Complete output:
    > # This file is part of the standard setup for testthat.
    > # It is recommended that you do not modify it.
    > #
    > # Where should you do additional test configuration?
    > # Learn more about the roles of various files in:
    > # * https://r-pkgs.org/tests.html
  ...
      6. │     └─rlang::eval_bare(quo_get_expr(.quo), quo_get_env(.quo))
      7. ├─simple_ensemble() %>% add_member(none_mars)
      8. ├─tidysdm::add_member(., none_mars)
      9. └─tidysdm:::add_member.tune_results(., none_mars)
     10.   └─(utils::getFromNamespace("choose_metric", "tune"))(metric, member)
     11.     └─tune::check_metric_in_tune_results(mtr_info, metric, call = call)
  
    [ FAIL 6 | WARN 10 | SKIP 0 | PASS 153 ]
    Error: Test failures
    Execution halted

• checking re-building of vignette outputs ... ERROR

  Error(s) in re-building vignettes:
  --- re-building ‘a0_tidysdm_overview.Rmd’ using rmarkdown
  
  Quitting from lines 362-365 [unnamed-chunk-13] (a0_tidysdm_overview.Rmd)
  Error: processing vignette 'a0_tidysdm_overview.Rmd' failed with diagnostics:
  missing value where TRUE/FALSE needed
  --- failed re-building ‘a0_tidysdm_overview.Rmd’
  
  --- re-building ‘a1_palaeodata_application.Rmd’ using rmarkdown
  
  ...
  --- finished re-building ‘a2_tidymodels_additions.Rmd’
  
  --- re-building ‘a3_troubleshooting.Rmd’ using rmarkdown
  --- finished re-building ‘a3_troubleshooting.Rmd’
  
  SUMMARY: processing the following files failed:
    ‘a0_tidysdm_overview.Rmd’ ‘a1_palaeodata_application.Rmd’
  
  Error: Vignette re-building failed.
  Execution halted

What's next

Some of these issues were addressed in #36. I'll be submitting a pull request here in a moment that makes fixes for the remaining breakages you see. We'll be sending the new version of tune to CRAN in two weeks; in the meantime, could you take a look at this PR and submit a version of your package to CRAN that incorporates the needed changes?

Related to https://github.com/tidymodels/tune/issues/864.

[dramanica]

This is now fixed in version 0.9.4, which is officially on CRAN.