search

EvolveLabs / electron-plugins

Plugin loader for electron applications.
MIT License
58 stars 11 forks source link

Plugins naming convention #2

Closed alvarolorentedev closed 8 years ago

alvarolorentedev commented 8 years ago

hello i am finding strange that I am forced to name my plugins at least following the example:

<name of the app>-<name of the plugin>

if is not like that i get the next crash: image am i doing something worng? is there a gracefulier way to treat the failure of plugin loading?

justinmchase commented 8 years ago

I'm not sure I understand. I don't think there is any enforced naming convention on the plugin. What is the name of your plugin so I can investigate it some?

alvarolorentedev commented 8 years ago

i am using your projects default plugin. as per i didnt saw anything relating to the app it depends on in neither the code or the package.json, am i missing something? I have push and tagged the failing code if you want to have a look.

alvarolorentedev commented 8 years ago

ok i was looking at why this happens and its when the main package is not publish in npm (even if the plugin is publish). I will look more into it...but it might be bot a problem in electron-plugins but more in electron updater. Anyway it has a work around that is publish the main package.