Feature/composite interaction base

[will-saunders-ukaea]

Description

Please include a summary of changes, motivation and context for this PR.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

• [ ] Bug fix (non-breaking change)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] API change (breaks downstream workflows and requires major semver bump)
• [ ] Requires documentation updates

Testing

Please describe the tests that you ran to verify your changes and provide instructions for reproducibility. Please also list any relevant details for your test configuration.

• [ ] Test Foo in /test/path/to/file_for_test_Foo.cpp
  • Description of test Foo
• [ ] Test Bar in /test/path/to/file_for_test_Bar.cpp
  • Description of test Bar

Test Configuration:

• OS:
• SYCL implementation:
• MPI details:
• Hardware:

Checklist:

• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] New and existing unit tests pass locally with my changes
• [ ] Any new dependencies are automatically built for users via cmake
• [ ] I have used understandable variable names
• [ ] I have run clang-format against my *.hpp and *.cpp changes
• [ ] I have run cmake-format against my changes to CMakeLists.txt
• [ ] I have run black against changes to *.py
• [ ] I have made corresponding changes to the documentation
• [ ] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] My changes generate no new warnings

######### DELETE THIS AND BELOW #########

How-to:

1. Format C++ source code with clang-format

find ./src ./include ./test -iname \*.hpp -o -iname \*.cpp | xargs clang-format -i

2. Format cmake files with cmake-format

cmake-format -i CMakeLists.txt src/nektar/CMakeLists.txt test/CMakeLists.txt

3. Format python with black

find ./python -iname \*.py | xargs black

[will-saunders-ukaea]

I have updated the NP side such that this points at the dev branch rather than an I think this is ready for another review/tests running by someone else.

[JamesEdgeley]

I get some errors like this in the build phase for the dev branch of neso-particles using spack:

     509    In file included from /home/jedge/NESO/neso-particles/include/neso_particles/external_interfaces/common/../../compute_target.hpp:15:
     510    In file included from /home/jedge/NESO/neso-particles/include/neso_particles/containers/../loop/../sycl_typedefs.hpp:7:
     511    In file included from /home/jedge/.spack/opt/spack/linux-ubuntu22.04-icelake/gcc-11.4.0/intel-oneapi-compilers-2022.2.1-p55yrly2lxt7mhzrgsg35vdiancszqrd/compiler/2022.2.1/linux/bin-l
            lvm/../include/sycl/CL/sycl.hpp:16:
     512    In file included from /home/jedge/.spack/opt/spack/linux-ubuntu22.04-icelake/gcc-11.4.0/intel-oneapi-compilers-2022.2.1-p55yrly2lxt7mhzrgsg35vdiancszqrd/compiler/2022.2.1/linux/bin-l
            lvm/../include/sycl/CL/sycl/backend.hpp:18:
     513    In file included from /home/jedge/.spack/opt/spack/linux-ubuntu22.04-icelake/gcc-11.4.0/intel-oneapi-compilers-2022.2.1-p55yrly2lxt7mhzrgsg35vdiancszqrd/compiler/2022.2.1/linux/bin-l
            lvm/../include/sycl/CL/sycl/detail/backend_traits_opencl.hpp:26:
     514    In file included from /home/jedge/.spack/opt/spack/linux-ubuntu22.04-icelake/gcc-11.4.0/intel-oneapi-compilers-2022.2.1-p55yrly2lxt7mhzrgsg35vdiancszqrd/compiler/2022.2.1/linux/bin-l
            lvm/../include/sycl/CL/sycl/queue.hpp:20:
  >> 515    /home/jedge/.spack/opt/spack/linux-ubuntu22.04-icelake/gcc-11.4.0/intel-oneapi-compilers-2022.2.1-p55yrly2lxt7mhzrgsg35vdiancszqrd/compiler/2022.2.1/linux/bin-llvm/../include/sycl/CL
            /sycl/handler.hpp:1242:50: error: '__usmfill<RemotePoint>' is invalid; kernel name should be forward declarable at namespace scope
     516        kernel_parallel_for<KernelName, ElementType>(KernelFunc);

Am I using a compatible compiler?

[will-saunders-ukaea]

I'm using

intel-oneapi-compilers/2024.1.0-gcc-12.3.0-pcvjv7b
intel-oneapi-runtime/2024.1.0-oneapi-2024.1.0-ci4wevz
intel-oneapi-mpi/2021.12.1-oneapi-2024.1.0-ld7q7bt
intel-tbb/2021.9.0-oneapi-2024.1.0-fmgspbl
intel-oneapi-mkl/2024.0.0-oneapi-2024.1.0-3afo4xc

Intel were making noises about removing access to toolchains over a year (I think) hence I updated.

[JamesEdgeley]

Everything working now