ExchangeUnion / xud-docker

Streamlined setup of xud and all dependencies via docker 🐳
https://docs.exchangeunion.com
GNU Affero General Public License v3.0
5 stars 5 forks source link

Don't mount whole host drive ( "/") into containers #786

Open kilrau opened 3 years ago

kilrau commented 3 years ago

Is your feature request related to a problem? Please describe. Mounting the whole host drive into utils, causes issues on several operating systems and is not great from a security perspective. We are currently doing this to be able to check availability of the backup path on start of utils and prompt user to change if not available.

Describe the solution you'd like

reliveyy commented 3 years ago

mount backup path only after user entered backup path in flow

@kilrau You cannot append new volumes on a running contianer thus why we need to mount "/" into utils.

kilrau commented 3 years ago

Aware, so there will be container restarts needed whenever something like backup path or network path changes.

reliveyy commented 3 years ago

Aware, so there will be container restarts needed whenever something like backup path or network path changes.

Yes. But we also map "/" into xud container too. So there is no restart required for xud in the past. @kilrau