This issue records some trivial issues regarding the code style, bad naming, and trivial implementation approvement. Then we can centrally manage and address these issues. A new issue might be created to track the work when we address one of the following issues.
issues
[ ] In the command line, a stateless check should be performed on the input parameters, such as the operator and AVS addresses. This check can refer to the validation of the genesis state. There is a related code comment that can be referred to for this issue.
https://github.com/ExocoreNetwork/exocore/pull/61#discussion_r1647757393
[ ] The layer_zero_chain_id should be renamed to client_chain_id to support the client chains that do not use the layer zero protocol, such as Bitcoin. Additionally the redundant chain_id should be removed for the ClientChainInfo. And ExocoreLzAppAddress should be renamed to ExocoreGateWayAddress.
When addressing this issue, consider the compatibility of the launching node from the genesis, whether from the bootstrap or the general exported file.
https://github.com/ExocoreNetwork/exocore/blob/dd27216e030a40a521cf800bd5a606f9ea287e5b/proto/exocore/assets/v1/tx.proto#L24C9-L24C24
Description
This issue records some trivial issues regarding the code style, bad naming, and trivial implementation approvement. Then we can centrally manage and address these issues. A new issue might be created to track the work when we address one of the following issues.
issues
[ ] In the command line, a stateless check should be performed on the input parameters, such as the operator and AVS addresses. This check can refer to the validation of the genesis state. There is a related code comment that can be referred to for this issue. https://github.com/ExocoreNetwork/exocore/pull/61#discussion_r1647757393
[ ] Some RPCs use a map as the response when defined in the protobuf. It appears that maps cannot support pagination. It also introduces inconsistencies when providing related functions in the precompiled contract. The relevant code is as follows: https://github.com/ExocoreNetwork/exocore/blob/dd27216e030a40a521cf800bd5a606f9ea287e5b/proto/exocore/assets/v1/query.proto#L25
[ ] The implementation of some RPCs and command lines should consider pagination. This issue might depend on resolving the previous issue. The relevant code is as follows: https://github.com/ExocoreNetwork/exocore/blob/dd27216e030a40a521cf800bd5a606f9ea287e5b/proto/exocore/assets/v1/query.proto#L39
[ ] The
layer_zero_chain_idshould be renamed toclient_chain_idto support the client chains that do not use the layer zero protocol, such as Bitcoin. Additionally the redundantchain_idshould be removed for theClientChainInfo. AndExocoreLzAppAddressshould be renamed toExocoreGateWayAddress. When addressing this issue, consider the compatibility of the launching node from the genesis, whether from the bootstrap or the general exported file. https://github.com/ExocoreNetwork/exocore/blob/dd27216e030a40a521cf800bd5a606f9ea287e5b/proto/exocore/assets/v1/tx.proto#L24C9-L24C24[ ] Consider using an enum type to represent the signature type in the client chain information. https://github.com/ExocoreNetwork/exocore/pull/116#discussion_r1658371444