search

Exolius / SimpleBackup

A bukkit plugin to zip up specified maps at regular intervals.
20 stars 19 forks source link

Fixed pom.xml and updated deprecated methods #30

Open Derkades opened 7 years ago

Derkades commented 7 years ago

I removed bukkit API from source because spigot API includes bukkit. Source: https://www.spigotmc.org/wiki/spigot-maven/

I also updated deprecated date.getHours(), getMinutes() and, getSeconds() to use methods in the Calendar class (https://stackoverflow.com/questions/907170/java-getminutes-and-gethours)

Derkades commented 7 years ago

Should I submit pull requests or continue this as my own project? (credit will be given where credit is due)

RoboMWM commented 7 years ago

I removed bukkit API from source because spigot API includes bukkit.

Why though? What spigot API's does this project need?

Derkades commented 7 years ago

@RoboMWM The project included both "spigot-api" and "bukkit" as a dependency. It should be either (not both!), since spigot contains bukkit code. I chose spigot since bukkit is dead anyways. It will not harm compatibility as long as we don't use any spigot stuff (for example spigot's chatcolor class)

RoboMWM commented 7 years ago

Ah ok.

Btw I'm weary of PRs to this since the idea is to keep it "simple" lol.

Derkades commented 7 years ago

Well I've mainly removed redundant code :)

Exolius commented 7 years ago

Feel free to take over releases of this if you want to, i'm not particularly interested in minecraft anymore,

Derkades commented 7 years ago

Alright