use lammps error API - Githubissues

ExpHP / rsp2

phonons in rust

Apache License 2.0

2 stars 1 forks source link

use lammps error API #2

Closed ExpHP closed 7 years ago

ExpHP commented 7 years ago

Lammps' library.h has functions for error checking, which are only enabled when LAMMPS_EXCEPTIONS is defined.

This will require, at bare minimum:

[x] rebuilding lammps personally
[x] ~lammps-sys should have an exceptions feature~
[x] updating lammps-wrap

ExpHP commented 7 years ago

done in upcoming commit.

decided against an exceptions feature and instead chose to just require it to be enabled. Ultimately it seems that the dynamic linking strategy for lammps-sys is simply not a good idea to begin with (since it requires separately configuring the rust package to use options similar to what Lammps was separately built with), and it is not worthwhile to devote too much energy into it