search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.36k stars 2.78k forks source link

iOS - Conversation - If the last message is deleted, the previous one becomes partially hidden #10765

Closed kbecciv closed 1 year ago

kbecciv commented 2 years ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Open the App and login with any account
  2. Go to any conversation
  3. Send 2 or more messages
  4. Delete the latest message

Expected Result:

The previous message should not be hidden

Actual Result:

The previous message becomes partially hidden

Workaround:

Unknown

Platform:

Where is this issue occurring?

Version Number: 1.1.96.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/188025493-15d3a984-ccec-4e20-8706-7deae4c33626.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

JmillsExpensify commented 1 year ago

Asked for an update in the linked PR.

JmillsExpensify commented 1 year ago

@Santhosh-Sellavel When you have a second, do you mind circling back and reviewing the linked PR? @ctkochan22 this one is ready for you as well!

mvtglobally commented 1 year ago

Issue not reproducible during KI retests. (Second week)

JmillsExpensify commented 1 year ago

@ctkochan22 Can you please jump in to review the linked PR? @Santhosh-Sellavel and @advaitasol9 have a question there so this PR can get merged.

JmillsExpensify commented 1 year ago

Still awaiting @ctkochan22's review in the linked PR.

mvtglobally commented 1 year ago

Issue not reproducible during KI retests. (Third week)

ctkochan22 commented 1 year ago

Yikes, sorry. Slipped through the cracks looking now

JmillsExpensify commented 1 year ago

Thanks! Also let's get real. I just tested this issue, and like Applause, I can't reproduce any longer. @Santhosh-Sellavel @advaitasol9 can either of you?

Santhosh-Sellavel commented 1 year ago

I can't reproduce it either, please can you confirm @advaitasol9

advaitasol9 commented 1 year ago

let me check @Santhosh-Sellavel.

advaitasol9 commented 1 year ago

@JmillsExpensify @ctkochan22 @Santhosh-Sellavel I am still able to reproduce this issue, attaching a video here (with latest main branch). Important: steps to reproduce.

  1. Open a chat where recipient is from a different timezone (so that recipient timezone is visible just above chat input).
  2. Use an ios simulator with mac's 'Connect Hardware Keyboard' disabled, so that keyboard is visible.
  3. Keep keyboard open while deleting messages as seen in video.
  4. The issue occurs randomly, i was unable to detect any pattern. So best way to reproduce is to send multiple messages (5-6) and keep deleting the last message until you observe the issue.

I hope this helps you to reproduce the issue.

Santhosh-Sellavel commented 1 year ago

I'm trying the same but am unable to reproduce it.

@kbecciv Can you check with the above steps?

kbecciv commented 1 year ago

@Santhosh-Sellavel Sorry, I don't have Mac to check. Do you want me to check on regular device again?

JmillsExpensify commented 1 year ago

I still can't reproduce this. Just tried on iOS, Desktop, mWeb (Safari). Also tried with someone that's in a different time zone and wasn't able to reproduce either. I think if the issue occurs randomly, we should focus on the bugs that are approving consistently (though of course, if we do, any Contributors would be paid out).

Santhosh-Sellavel commented 1 year ago

@kbecciv Please check on regular devices that would be enough, if it occurs only simulator we can ignore that!

JmillsExpensify commented 1 year ago

I agree with that. While I do think it's helpful to find and fix issues in the simulator, I think for now we have so many bugs in production we should be focused on fixing those.

kbecciv commented 1 year ago

Issue is no longer reproduced with build 1.2.27.4

https://user-images.githubusercontent.com/93399543/201950211-3022a20d-a004-4d6c-a5d3-20baf9ab47d7.MP4

JmillsExpensify commented 1 year ago

Ok with that in mind, I think we should close this issue and pay out C and C+ for their time/work.

JmillsExpensify commented 1 year ago

That said, an additional consideration is this: What do we want to do with @advaitasol9's PR? Do nothing? cc @Santhosh-Sellavel @ctkochan22 let's make sure we're on the same page for next steps.

mvtglobally commented 1 year ago

Issue not reproducible during KI retests. (Fourth week)

ctkochan22 commented 1 year ago

@advaitasol9 Bump to my question in the PR https://github.com/Expensify/App/pull/11752#issuecomment-1308201478

If you can help us reproduce it, it'll get the PR moving forward. Otherwise, I think we should close the issue and the PR

Santhosh-Sellavel commented 1 year ago

@ctkochan22 Please follow the thread from here, we are unable to reproduce. Here are the steps given by @advaitasol9, but still no luck for us, please give it a try, thanks!

ctkochan22 commented 1 year ago

@Santhosh-Sellavel thanks for clarifying. I'm still unable to reproduce. I'm not sure why.

Even so, the padding normal 4 out of 5 times. Why is it not normal the 5th time? This PR is not a fix. It just covers up the actual bug.

advaitasol9 commented 1 year ago

Hi @ctkochan22, I think it is already established that the issue itself is not consistent, occurs once every 5-6 times and only when recipient time is visible. The difference between a chat with and without recipient time is the top padding that the list has.

This PR suggests and proves that when we follow the same padding as when recipient time is not visible the issue doesn't occur. I don't see how that can be called a coverup.

JmillsExpensify commented 1 year ago

@ctkochan22 Thoughts on that last comment?

ctkochan22 commented 1 year ago

Okay so this only happens to users when the recipient time is visible?

What causes the message to be hidden? And why doesn't it do it every time?

advaitasol9 commented 1 year ago

@ctkochan22 the way it happens only on ios when keyboard is open, my guess is it should be an issue internally with Flatlist.

ctkochan22 commented 1 year ago

Okay, so it sounds like we should bring this internal and fix it at the root. I'll try and take a look this week

JmillsExpensify commented 1 year ago

Thanks so much! Heads up @ctkochan22, we may be deprecating FlatList for WishList in the near future, though it's still probably too early with the later to definitely say we should close this issue.

mvtglobally commented 1 year ago

Issue not reproducible during KI retests. (Fifth week)

advaitasol9 commented 1 year ago

Hi @JmillsExpensify, what'd be the next steps for me. If anything is required I'm here to help. If not, can we move forward to payment?

ctkochan22 commented 1 year ago

@advaitasol9 I believe you need to be hired and your proposal to be accepted and merged.

advaitasol9 commented 1 year ago

I know @ctkochan22, I was hired and my proposal was accepted. Based on my pr I feel this issue is being taken internal. This is a unusual situation, that's why I am asking what would be next steps.

JmillsExpensify commented 1 year ago

@advaitasol9 To clarify my earlier comment, I was saying that we should still resolve this issue despite us looking into FlatList alternatives longer-term. Further, I wanted to re-assure you that if we do take this internal, you will be compensated for whatever work you've done to date.

@ctkochan22 If we are taking this issue internal, as you mention here, are you leading this up? It'd be good to get clarify on next steps.

ctkochan22 commented 1 year ago

It was accepted, but after reviewing the PR, I think we agreed that the root issue is not being fixed.

We need to address why its making that jump. So I think the PR and previously accepted proposal is no longer valid

JmillsExpensify commented 1 year ago

Ok gotcha. I think that's on us then and we owe the contributor for making that mistake. We probably need to take the discussion about the detailed solution to slack. Can you take that on?

ctkochan22 commented 1 year ago

Ah, thats good to know, sorry about the confusion @advaitasol9 !

Yeah I can take this on

JmillsExpensify commented 1 year ago

Ok cool. @advaitasol9 I've unassigned you from this issue and issued payment via Upwork. @Santhosh-Sellavel I think in your case you'll be needed still on the PR review, so I've hired you as is in the Upwork job and we can settle up after this PR gets merged.

Santhosh-Sellavel commented 1 year ago

@ctkochan22 Let me know when PR is up, thanks!

JmillsExpensify commented 1 year ago

@ctkochan22 I think you're out for a personal issue, though please update us on the PR when you return. Thanks!

JmillsExpensify commented 1 year ago

@ctkochan22 Can you circle back today and update us on the PR status?

ctkochan22 commented 1 year ago

Was catching up, investigating this bug today and tomorrow

JmillsExpensify commented 1 year ago

Discussing in Slack as well.

JmillsExpensify commented 1 year ago

I'm going to unassign Chris, as he's OOO. Going to work on finding a volunteer!

JmillsExpensify commented 1 year ago

Posted in Slack!

bondydaa commented 1 year ago

I'm a little confused, it seems like this wasn't reproducible anymore? Or was it that it isn't consistently reproducible?

looks like https://github.com/Expensify/App/pull/11752 was closed and looks like we paid out the PR author.

I'll run some tests to see if I can reproduce it at all but if I can't we should just close right?

JmillsExpensify commented 1 year ago

Actually that's interesting! I can't reproduce this either anymore. Awesome to have a fresh set of eyes. Let's go ahead and close this one out.

JmillsExpensify commented 1 year ago

Also @Santhosh-Sellavel you are settled up. 🙌🏼