[HOLD for payment 2023-06-01] [$1000] Show up to 4 participant avatars in the IOUPreview for a bill split

[Julesssss]

Problem

We introduced the IOUPreview for bill splits https://github.com/Expensify/Expensify/issues/270707. But we are only showing one avatar in the IOUPreview when a bill split is created. Instead, we should show up to 4, or 3 if more than 4 participants are included in the split.

Current

Desired

In addition, we should make sure the same order is used when the split is created while offline. (So when returning online, the order shouldn't change)

Solution

Yes please.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a91334bf09c52786
• Upwork Job ID: 1658476194782515200
• Last Price Increase: 2023-05-16

[s77rt]

May be related https://github.com/Expensify/App/issues/15644

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Show up to 4 participant avatars in IOUPreview for split bill

What is the root cause of that problem?

The root cause is that we're not using the prop shouldStackHorizontally here.

What changes do you think we should make in order to solve the problem?

We need to add shouldStackHorizontally and set size prop to small. Additionally, the secondAvatarStyle prop needs to be removed. These changes need to be done here only if the isBillSplit is true.

What alternative solutions did you explore? (Optional)

None

[melvin-bot[bot]]

@Julesssss Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot[bot]]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [x] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [x] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [x] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [x] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [x] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01a91334bf09c52786

[melvin-bot[bot]]

Current assignee @flaviadefaria is eligible for the External assigner, not assigning anyone new.

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[melvin-bot[bot]]

Current assignee @Julesssss is eligible for the External assigner, not assigning anyone new.

[Julesssss]

The proposal from @allroundexperts looks good to me. @aimane-chnaif would you mind reviewing this before I assign it? Thanks

[aimane-chnaif]

Proposal looks good to me too. @allroundexperts let's make sure order doesn't change when become online from offline And need to customize styles. It looks ugly without them:

https://github.com/Expensify/App/assets/96077027/4aa2960b-dc35-4428-ac0a-b7e22524486c

[allroundexperts]

Proposal looks good to me too. @allroundexperts let's make sure order doesn't change when become online from offline And need to customize styles. It looks ugly without them:

Screen.Recording.2023-05-16.at.4.26.13.PM.mov

@aimane-chnaif Sure thing.

[Julesssss]

Great, let's get this done

[melvin-bot[bot]]

📣 @allroundexperts You have been assigned to this job by @Julesssss! Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[allroundexperts]

PR created https://github.com/Expensify/App/pull/19074

[flaviadefaria]

I'm OoO for 8 days so re-adding the BUG label, but keeping myself assigned. I'll be back at work on May 30th.

[melvin-bot[bot]]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.17-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/19074

If no regressions arise, payment will be issued on 2023-06-01. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter
• [ ] Contributor that fixed the issue
• [ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [x] [@allroundexperts / @aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [x] [@allroundexperts / @aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [x] [@allroundexperts / @aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [x] [@allroundexperts / @aimane-chnaif] Determine if we should create a regression test for this bug.
• [x] [@allroundexperts / @aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [x] [@zanyrenney / @flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[flaviadefaria]

@aimane-chnaif can you please fill out the checklist above so that I can issue payment? Thanks!

[aimane-chnaif]

This is not a bug bug feature request. No regression tests needed. This is part of rolling out a new feature [manual request] and comprehensive regression test will be updated for money request pages.

[flaviadefaria]

@allroundexperts and @aimane-chnaif I'm sending you offers in UW. $1000 + $500 bonus = $1500 total payment for each of you.

[flaviadefaria]

Everyone has been paid so closing this.