Split money message tooltip and share code displays phone number with @expensify.sms

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Login with phone number user
3. Open settings
4. Open Share code
5. Observe that number is displayed with @expensify.sms
6. Close the side menu and open and group report
7. Do the split bill flow and hover on profile pics in split bill message to observe that number is displayed with @expensify.sms

Expected Result:

App should not display @expensify.sms after contact number

Actual Result:

App displays @expensify.sms after contact number in share code and on tooltip when hovered over profiles in split bill message

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android / native
• [x] Android / Chrome
• [x] iOS / native
• [x] iOS / Safari
• [x] MacOS / Chrome / Safari
• [x] MacOS / Desktop

Version Number: 1.3.19-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/43996225/07048f29-3c07-46e4-9a7f-84f82e69e975

https://github.com/Expensify/App/assets/43996225/95d659c9-8af0-4283-997c-76722da41930

Expensify/Expensify Issue URL: Issue reported by: @dhanashree-sawant Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684849196517579

View all open jobs on GitHub

[melvin-bot[bot]]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [x] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [x] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [x] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [x] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

@expensify.sms domain being shown at various places

What is the root cause of that problem?

We're not checking if the user login is a phone number and displaying the login directly here and here.

What changes do you think we should make in order to solve the problem?

We need to use the following here:

Str.isSMSLogin(personalDetail.login) ? LocalePhoneNumber.formatPhoneNumber(personalDetail.login) : personalDetail.login

Also, the following needs to be used here:

this.props.formatPhoneNumber(this.props.session.email)

What alternative solutions did you explore? (Optional)

None

[jliexpensify]

Dupe of https://github.com/Expensify/App/issues/19500