search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.36k stars 2.79k forks source link

[HOLD for payment 2023-06-19] [HOLD for payment 2023-06-15] Group - The IOU details page for split bill doesn't have close button [X] #20408

Closed lanitochka17 closed 1 year ago

lanitochka17 commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Launch App
  2. Create Group
  3. Open the DM create menu (note below) again and select Split Bill
  4. Select all the participants and hit "Split Bill"
  5. Tap on the IOU details > try to close it

Expected Result:

The IOU details page should have close button [X]

Actual Result:

The IOU details page for split bill doesn't have close button [X]

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.25.3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/78819774/aa53e966-7966-4334-855c-5ce255802101

Bug6083897_close

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

OSBotify commented 1 year ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

ahmedGaber93 commented 1 year ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Group - The IOU details page for split bill doesn't have close button [X]

What is the root cause of that problem?

We use header without close button here https://github.com/Expensify/App/blob/eb718c0b643bda48b806bb9a1e52235815e3e9c6/src/pages/iou/SplitBillDetailsPage.js#L78-L81

What changes do you think we should make in order to solve the problem?

add shouldShowCloseButton and onCloseButtonPress props here like this.

    <HeaderWithBackButton
          title={props.translate('common.details')}
          shouldShowBackButton={false}
          shouldShowCloseButton // <<<<<<<<<<<<<<<<<<<<
          onCloseButtonPress={() => Navigation.dismissModal()} // <<<<<<<<<<<<<<<<<<<<
      />

What alternative solutions did you explore? (Optional)

we can use back button instead of close button by add this props shouldShowBackButton and onBackButtonPress

melvin-bot[bot] commented 1 year ago

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

dangrous commented 1 year ago

So ha, I was just looking into this and was going to write what @ahmedGaber93 wrote . However, what I discovered was that adding shouldShowCloseButton doesn't actually pass the props correctly, it's still just taking the default value. This is also true for the existing shouldShowBackButton={false}. I'm not entirely sure why but that could be the issue.

The new default of false for shouldShowCloseButton was updated here - https://github.com/Expensify/App/pull/18402/files#diff-1e4d0651892fd099137cb93a35cf263dc385cc124164c5c14bcf067fd2f973eaR114 which seems to be causing the issue.

However I'm not sure whether the issue is an incorrect default, or whether something has happened to this component to cause it to no longer take props. cc @mountiny and @MariaHCD since you reviewed the PR. Will look into it more in a second.

dangrous commented 1 year ago

or wait is this not a blocker? Is this intentional? https://github.com/Expensify/App/issues/15850

mountiny commented 1 year ago

The missing X is intentional but there should be the UP/ back button which was not added to the page, are you abel to handle the fix?

mountiny commented 1 year ago

This is in staging, no payments required, closing

melvin-bot[bot] commented 1 year ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 year ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.25-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-15. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

melvin-bot[bot] commented 1 year ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.26-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-19. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

As a reminder, here are the bonuses/penalties that should be applied for any External issue: