Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.36k stars 2.78k forks source link

Split Bill - First created bill description is not empty #20505

Closed kbecciv closed 1 year ago

kbecciv commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR https://github.com/Expensify/App/pull/20115

Action Performed:

  1. Create a split bill
  2. Add All necessary info and description.
  3. Create split bill.
  4. Create another split bill.
  5. Open the previously created bill.
  6. Description and currency is as expected.
  7. Create a split bill with empty description and also change the currency.
  8. Create a new split bill with some description.

Expected Result:

Open the first created split bill, description should be empty and currency should be the same that when created.

Actual Result:

Split bill description is not empty but currency is correct

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.26.1

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/6db46e7b-406b-45e8-b8c7-8655238c1643

Expensify/Expensify Issue URL:

Issue reported by: Applause - internal Team

Slack conversation:

View all open jobs on GitHub

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

c3024 commented 1 year ago

Third split bill description is empty and others have non-empty descriptions. What is the bug? Could you please explain?

joekaufmanexpensify commented 1 year ago

I agree. i think this is expected behavior. In the other issue, the bug was that we were overwriting description in an existing IOU, when creating another one.

Here the bug report seems to be that we are not doing this. But that's not a bug. When a new bill split is created, we should not overwrite the description of an existing bill split.

@Julesssss mind sense checking my thinking here as you worked on the other issue? IMO, we should close this.

Julesssss commented 1 year ago

Yeah, I'm also confused by this report. It seems to be working correctly to me (but @kbecciv are we missing something?)

I'm going to close it in the meantime