[Hold for #20736] [$1000] Search in new group does not delete current search after result selection like it does in split bill search

kbecciv commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open the app
Click on plus
Click on split bill
Search for specific user, select the user and observe the after selecting the result, it deletes the search term
Go back to homepage and click on plus
Click on new group
Search for specific user, select the user and observe the after selecting the result, it does not delete the search term

Expected Result:

New group search should delete the search term after result is selected like it does for split bill search

Actual Result:

New group search does not delete the search term after result is selected

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.28.3

Reproducible in staging?: y

Reproducible in production?: y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/e45730c8-7a8a-4f4b-a473-7442310862ae

https://github.com/Expensify/App/assets/93399543/03a4648f-3078-4b09-829b-f4c02160cbd7

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686414344686509

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b80145a518fadfab
Upwork Job ID: 1670781126334717952
Last Price Increase: 2023-07-03

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

[x] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[x] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[x] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[x] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

dukenv0307 commented 1 year ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search in new group does not delete current search after result selection like it does in split bill search

What is the root cause of that problem?

In the SplitBill we only retain text input if the user unselects a member and we will clear text input if the user selects a user https://github.com/Expensify/App/blob/7b00c47ee7debf7137417ac768efe8d4c6b872d0/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSplitSelector.js#L199

Note that: In all other multi-selection places (new group, manage member, invite member), we always retain search input when the user selects or unselects a member

What changes do you think we should make in order to solve the problem?

In all other multi-selection places (new group, manage member, invite member) we should clear text instead of retaining text when the user selects a new option

In here https://github.com/Expensify/App/blob/0e02294662915e4defcba30496a68faa876a316c/src/pages/NewChatPage.js#L186 We should update like this

searchTerm: isOptionInList ? prevState.searchTerm : '',

Do the same thing on manage member, invite member page

What alternative solutions did you explore? (Optional)

melvin-bot[bot] commented 1 year ago

Job added to Upwork: https://www.upwork.com/jobs/~01b80145a518fadfab

melvin-bot[bot] commented 1 year ago

Current assignee @NicMendonca is eligible for the External assigner, not assigning anyone new.

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

BhuvaneshPatil commented 1 year ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search in new group does not delete current search after result selection like it does in split bill search

What is the root cause of that problem?

We are not setting the searchTerm value in NewChatPage component's toggleOption() method. https://github.com/Expensify/App/blob/297e5aa46582fb2681dc9e5e64a075c5da8dcdd7/src/pages/NewChatPage.js#L159-L188

What changes do you think we should make in order to solve the problem?

Update the state with appropriate value, i.e. ''
Update the getNewChatOptions() method in toggleOption()

Results

https://github.com/Expensify/App/assets/27822551/29d06dc5-d5f4-46d6-830c-539d6ef5e884

What alternative solutions did you explore? (Optional)

As mentioned in https://github.com/Expensify/App/issues/20948#issuecomment-1595335780 We can alternatively remove the functionality from Split Bill or else add the same functionality (deleting search term ) in other components.

fedirjh commented 1 year ago

Thanks for the proposals @dukenv0307 and @BhuvaneshPatil , it seems that the Split Bill has a different behaviour compared to other pages ( new group, manage members and invite members) which made me wonder of which behaviour should we follow.

cc @NicMendonca What are your thoughts on the expected behaviour ? should we :

🅰️ Fix Split Bill page and make it consistent with other pages , making the search term persist after selecting a user.
🅱️ Fix other pages and remove the search term after selecting a user.

NicMendonca commented 1 year ago

@fedirjh let's bring this up for a discussion in Slack! I think the search term should persist (like slack), but I am just 1 voice 😃

fedirjh commented 1 year ago

Started a discussion here https://expensify.slack.com/archives/C01GTK53T8Q/p1687282549853709

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

NicMendonca commented 1 year ago

@flaviadefaria I am going OOO until Wednesday. Can you watch this while I am away? I'll unassign you when I am back. Thank you!

melvin-bot[bot] commented 1 year ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 1 year ago

@NicMendonca, @fedirjh, @flaviadefaria Whoops! This issue is 2 days overdue. Let's get this updated quick!

fedirjh commented 1 year ago

Discussion is here https://expensify.slack.com/archives/C01GTK53T8Q/p1687792094006749?thread_ts=1687282549.853709&cid=C01GTK53T8Q

flaviadefaria commented 1 year ago

Added my thoughts in the thread. I think there are 3 of us agreeing on the same solution so unless someone weighs in in the other direction I think we're good to move forward.

dukenv0307 commented 1 year ago

@fedirjh Updated proposal

NicMendonca commented 1 year ago

Still discussing: https://expensify.slack.com/archives/C01GTK53T8Q/p1688048316941109?thread_ts=1687282549.853709&cid=C01GTK53T8Q

melvin-bot[bot] commented 1 year ago

@NicMendonca @fedirjh this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

fedirjh commented 1 year ago

cc @NicMendonca Let's hold this issue for https://github.com/Expensify/App/pull/20736, this PR will fix the Split bill search which I think will make the behavior consistent and we may not need to proceed with this issue.

melvin-bot[bot] commented 1 year ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

NicMendonca commented 1 year ago

updated

fedirjh commented 1 year ago

@NicMendonca Looks like the behavior is consistent now and this issue should be closed.

Expensify / App