[$1000] [HOLD for payment 2023-06-29] Web - Split Bill - Details page is shown empty for old group chat splits

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging dot on web chrome
2. Go to any old group chat where you splitted the bill (Important- split bill report)
3. Click on it and notice that details page is empty
4. But if you split the bill now in the same group and then click on the split bill report, you'll be able to see the details without any problem. Thus the problem occurs for old split bills and not the new ones.

Expected Result:

Details page should be not shown empty for old group chat splits

Actual Result:

Details page is shown empty for old group chat splits

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native
• [ ] Android / Chrome
• [ ] iOS / native
• [ ] iOS / Safari
• [x] MacOS / Chrome / Safari
• [ ] MacOS / Desktop

Version Number: 1.3.29.3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/6b620810-19eb-4044-9120-6b4c0f94dafb

https://github.com/Expensify/App/assets/93399543/29033e53-6d25-42f3-9c91-a02928c360dc

Expensify/Expensify Issue URL:

Issue reported by: @priya-zha

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687167180014059

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01034e11a536cbe311
• Upwork Job ID: 1673377762610040832
• Last Price Increase: 2023-06-26

[OSBotify]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot[bot]]

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[roryabraham]

The problem here is that we changed the shape of reportActions data to go from originalMessage.participants -> originalMessage.participantAccountIDs and didn't migrate old reportActions...

[aldo-expensify]

I chatted with Alex. B about this and it seems like we didn't migrate the database data. I'll try to prepare a CQ query to migrate.

[luacmartins]

Removing the blocker label as per this comment

[luacmartins]

This was fixed, CPed and deployed to prod. No payments are due. Closing.

[priya-zha]

@luacmartins I'm the external reporter for this issue.

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.30-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/21161

If no regressions arise, payment will be issued on 2023-06-29. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter
• [ ] Contributor that fixed the issue
• [ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[luacmartins]

Sorry, I missed that @priya-zha. Reopening and adding Bug label to get payment sorted out.

[melvin-bot[bot]]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[luacmartins]

@johncschuster we just need to pay the reporting bonus to @priya-zha

[luacmartins]

Just missing reporting bonus payment to @priya-zha

[johncschuster]

Thanks for the callout, @luacmartins! I'll have a job created so I can pay the reporting bonus.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01034e11a536cbe311

[melvin-bot[bot]]

Current assignee @johncschuster is eligible for the External assigner, not assigning anyone new.

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[johncschuster]

Sorry for the ping, @mollfpr. I applied the External label just to create the Upwork job to pay the reporting bonus.

[johncschuster]

@priya-zha, can you apply for the job above?

[priya-zha]

@johncschuster proposal submitted. thanks

[melvin-bot[bot]]

📣 @mentamarindos! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Format:

   Contributor details
   Your Expensify account email: <REPLACE EMAIL HERE>
   Upwork Profile Link: <REPLACE LINK HERE>

[lealobanov]

Contributor details Your Expensify account email: lea.lobanov@icloud.com Upwork Profile Link: https://www.upwork.com/freelancers/~0187e5647dc5b9d97e

[melvin-bot[bot]]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot[bot]]

📣 @phoenixdevguru! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Format:

   Contributor details
   Your Expensify account email: <REPLACE EMAIL HERE>
   Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot[bot]]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[johncschuster]

Hi @phoenixdevguru, this issue has already been resolved. We're just working on issuing payment to the bug reporter.

[johncschuster]

Payment has been issued! I think we're good to close this out.