Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.36k stars 2.79k forks source link

[$1000] IOU reports missing requested amount in LHN after signing out #21894

Closed kbecciv closed 1 year ago

kbecciv commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Log in to NewDot
  2. Split a bill with a user you have no chat/IOU history with
  3. Note that "requested..." shows under the newly created IOU report in LHN
  4. Sign out
  5. Sign back in and look at the IOU report in LHN

Expected Result:

The IOU report's "requested..." amount should still show in LHN

Actual Result:

"This is the beginning of your chat with..." message displays instead

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: v1.3.33-3 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/918e711b-739d-435d-8b05-ae5a0eb8ac44

https://github.com/Expensify/App/assets/93399543/36ea0d37-0583-480e-8b97-89f6f3326437

Expensify/Expensify Issue URL: Issue reported by: @jjcoffee Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687967224935879

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019e5620a5834dcbbc
  • Upwork Job ID: 1676009777577394176
  • Last Price Increase: 2023-07-10
melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

melvin-bot[bot] commented 1 year ago

Job added to Upwork: https://www.upwork.com/jobs/~019e5620a5834dcbbc

melvin-bot[bot] commented 1 year ago

Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

michaelhaxhiu commented 1 year ago

fielding proposals

alitoshmatov commented 1 year ago

So it looks like backend is not sending needed fields for iou type reports, for example create some kind of iou(request, send or split) then in the created report send any message, after signing out and logging back in you see This is the beginning of your chat with. These are iou reports which is send initially when you sign in

Screenshot 2023-07-04 at 4 52 53 PM Screenshot 2023-07-04 at 4 53 16 PM

After you go to report it will make openReport request and then backend is sending required fields, like lastMessageHtml, lastMessageText, lastReadTime but not limited to these

Screenshot 2023-07-04 at 4 53 58 PM
melvin-bot[bot] commented 1 year ago

@michaelhaxhiu, @mollfpr Whoops! This issue is 2 days overdue. Let's get this updated quick!

mollfpr commented 1 year ago

Thanks @alitoshmatov

IOU from OpenApp Thread from OpenApp IOU from OpenReport
Screenshot 2023-07-10 at 10 13 59 Screenshot 2023-07-10 at 10 23 31 Screenshot 2023-07-10 at 10 15 32

@michaelhaxhiu It seems this is an internal issue since need a backend change for the IOU report on the OpenApp API. As explained above from @alitoshmatov we need some of the fields in the IOU report.

melvin-bot[bot] commented 1 year ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 1 year ago

Current assignee @mollfpr is eligible for the Internal assigner, not assigning anyone new.

michaelhaxhiu commented 1 year ago

Thanks for your insight Luthfi and @alitoshmatov <3

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

michaelhaxhiu commented 1 year ago

Adding Internal label to march this forward

melvin-bot[bot] commented 1 year ago

@AndrewGable @michaelhaxhiu @mollfpr this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

michaelhaxhiu commented 1 year ago

cc @AndrewGable lil bump on this guy - do you foresee having some time to work on this in the coming week?

melvin-bot[bot] commented 1 year ago

@AndrewGable @michaelhaxhiu @mollfpr this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

melvin-bot[bot] commented 1 year ago

@AndrewGable, @michaelhaxhiu, @mollfpr Whoops! This issue is 2 days overdue. Let's get this updated quick!

michaelhaxhiu commented 1 year ago

Andrew is OOO till tomorrow so let's hold a little

michaelhaxhiu commented 1 year ago

let's give andy 1 more day

AndrewGable commented 1 year ago

I do not forsee myself being able to work on this for a while

melvin-bot[bot] commented 1 year ago

@AndrewGable @michaelhaxhiu @mollfpr this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

michaelhaxhiu commented 1 year ago

@AndrewGable got it! Should we look for a volunteer to take it over? Or do you want to keep it and take a stab in the next 1 - 2 weeks?

Not my intention to hassle ya, just trying to maintain WAQ 🙏

AndrewGable commented 1 year ago

Feel free to find a volunteer! 👍

michaelhaxhiu commented 1 year ago

Posted in #engineering-chat for a volunteer

https://expensify.slack.com/archives/C03TQ48KC/p1691077804921719

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

michaelhaxhiu commented 1 year ago

Note: I'm preparing to go OOO for ~2 weeks and going to assign another BZ to oversee this.

Next steps:

Thanks in advance!

melvin-bot[bot] commented 1 year ago

@puneetlath, @AndrewGable, @mollfpr Whoops! This issue is 2 days overdue. Let's get this updated quick!

aldo-expensify commented 1 year ago

The may have been fix after the deploy of: https://github.com/Expensify/Auth/pull/8362

You should be getting all IOU/expense reports, but there may be a different bug where they don't have the right state until you click them. This last part should get corrected by https://github.com/Expensify/Web-Expensify/pull/37388

puneetlath commented 1 year ago

Oh nice!

AndrewGable commented 1 year ago

@puneetlath @kbecciv - Can we get a re-test? I think that linked PR was deployed to production recently.

puneetlath commented 1 year ago

Just tested and it does indeed seem to work. Closing out.