Closed kbecciv closed 1 year ago
Triggered auto assignment to @michaelhaxhiu (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
Platforms
in OP are ✅)Job added to Upwork: https://www.upwork.com/jobs/~019e5620a5834dcbbc
Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External
)
fielding proposals
So it looks like backend is not sending needed fields for iou
type reports, for example create some kind of iou(request, send or split) then in the created report send any message, after signing out and logging back in you see This is the beginning of your chat with
.
These are iou reports which is send initially when you sign in
After you go to report it will make openReport
request and then backend is sending required fields, like lastMessageHtml
, lastMessageText
, lastReadTime
but not limited to these
@michaelhaxhiu, @mollfpr Whoops! This issue is 2 days overdue. Let's get this updated quick!
Thanks @alitoshmatov
IOU from OpenApp | Thread from OpenApp | IOU from OpenReport |
---|---|---|
@michaelhaxhiu It seems this is an internal issue since need a backend change for the IOU report on the OpenApp
API. As explained above from @alitoshmatov we need some of the fields in the IOU report.
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
Current assignee @mollfpr is eligible for the Internal assigner, not assigning anyone new.
Thanks for your insight Luthfi and @alitoshmatov <3
Triggered auto assignment to @AndrewGable (Engineering
), see https://stackoverflow.com/c/expensify/questions/4319 for more details.
Adding Internal
label to march this forward
@AndrewGable @michaelhaxhiu @mollfpr this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
cc @AndrewGable lil bump on this guy - do you foresee having some time to work on this in the coming week?
@AndrewGable @michaelhaxhiu @mollfpr this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!
@AndrewGable, @michaelhaxhiu, @mollfpr Whoops! This issue is 2 days overdue. Let's get this updated quick!
Andrew is OOO till tomorrow so let's hold a little
let's give andy 1 more day
I do not forsee myself being able to work on this for a while
@AndrewGable @michaelhaxhiu @mollfpr this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!
@AndrewGable got it! Should we look for a volunteer to take it over? Or do you want to keep it and take a stab in the next 1 - 2 weeks?
Not my intention to hassle ya, just trying to maintain WAQ 🙏
Feel free to find a volunteer! 👍
Posted in #engineering-chat for a volunteer
https://expensify.slack.com/archives/C03TQ48KC/p1691077804921719
Triggered auto assignment to @puneetlath (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
Note: I'm preparing to go OOO for ~2 weeks and going to assign another BZ to oversee this.
Next steps:
Thanks in advance!
@puneetlath, @AndrewGable, @mollfpr Whoops! This issue is 2 days overdue. Let's get this updated quick!
The may have been fix after the deploy of: https://github.com/Expensify/Auth/pull/8362
You should be getting all IOU/expense reports, but there may be a different bug where they don't have the right state until you click them. This last part should get corrected by https://github.com/Expensify/Web-Expensify/pull/37388
Oh nice!
@puneetlath @kbecciv - Can we get a re-test? I think that linked PR was deployed to production recently.
Just tested and it does indeed seem to work. Closing out.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
The IOU report's "requested..." amount should still show in LHN
Actual Result:
"This is the beginning of your chat with..." message displays instead
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: v1.3.33-3 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/918e711b-739d-435d-8b05-ae5a0eb8ac44
https://github.com/Expensify/App/assets/93399543/36ea0d37-0583-480e-8b97-89f6f3326437
Expensify/Expensify Issue URL: Issue reported by: @jjcoffee Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687967224935879
View all open jobs on GitHub
Upwork Automation - Do Not Edit