search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.36k stars 2.78k forks source link

[HOLD for payment 2023-07-17] [HOLD for payment 2023-07-14] Not able to split money on back button #22302

Closed kavimuru closed 1 year ago

kavimuru commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. On chrome staging website > FAB icon > Split Bill > Enter amount > Click Next >Select any user > Click Next to open up the split bill page ( Do NOT click split button)
  2. Now click on the user > Click back and see that the split money page is gone

    Expected Result:

    Back button should not end the split bill page

    Actual Result:

    Back button ends the split bill page

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.37-1 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/43996225/cd9f3625-1c70-45c6-8537-3de2dcf6c409

https://github.com/Expensify/App/assets/43996225/935b3d9e-6c1d-4a24-a505-aa8d819dc245

Expensify/Expensify Issue URL: Issue reported by: @Santhosh-Sellavel Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688586118022729

View all open jobs on GitHub

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

OSBotify commented 1 year ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
melvin-bot[bot] commented 1 year ago

Current assignee @puneetlath is eligible for the Engineering assigner, not assigning anyone new.

StevenKKC commented 1 year ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Back button ends the split bill page after open user detail page.

What is the root cause of that problem?

The following code is called if clicks the user on the split bill confirmation page. https://github.com/Expensify/App/blob/a2a521d9ac1f22ccf50cd973d7704d82337522da/src/components/MoneyRequestConfirmationList.js#L199-L204

The Money Request page and the Profile page are separate screens, seperate RHP flows. As a result, the following code will replace navigation routes. and the money request flow will be removed after navigating to the user profile page. https://github.com/Expensify/App/blob/a2a521d9ac1f22ccf50cd973d7704d82337522da/src/libs/Navigation/linkTo.js#L80-L90

Therefore clicking back will close the modal and end the split bill process.

What changes do you think we should make in order to solve the problem?

According to the above code comments, replacing routes when changing flow is intended. However, I think navigating from split bill or money request to user detail page should follow the same flow and not replace routes. We can change this line as below.

-   if (targetName === NAVIGATORS.RIGHT_MODAL_NAVIGATOR) {
+   if (targetName === NAVIGATORS.RIGHT_MODAL_NAVIGATOR && minimalAction.payload.name !== 'Profile') {

What alternative solutions did you explore? (Optional)

None.

melvin-bot[bot] commented 1 year ago

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

Julesssss commented 1 year ago

Same underlying cause as this issue. I'm going to close this and add this additional case to the issue description

Santhosh-Sellavel commented 1 year ago

@Julesssss But I reported this issue before the other one please check https://expensify.slack.com/archives/C049HHMV9SM/p1688507121082889

Julesssss commented 1 year ago

@Santhosh-Sellavel I documented this here on the other issue

Julesssss commented 1 year ago

My mistake. This is a slightly different issue and is still occurring 😖

Julesssss commented 1 year ago

Hi @StevenKKC, thanks for your proposal. Checking for a specific profile page name is flakey and doesn't seem to solve the underlying issue though.

mountiny commented 1 year ago

PR is up

Julesssss commented 1 year ago

Thank you @mountiny!

melvin-bot[bot] commented 1 year ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 year ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.37-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-07-14. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

melvin-bot[bot] commented 1 year ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

Santhosh-Sellavel commented 1 year ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [x] [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/21067
  • [x] [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/21067/files#r1257532582
  • [x] [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Here
  • [x] [@Santhosh-Sellavel] Determine if we should create a regression test for this bug. Yes
  • [x] [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. https://github.com/Expensify/App/issues/22302#issuecomment-1627808202
  • [ ] [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

cc: @mountiny Let me know if you differ on any of the above.

Santhosh-Sellavel commented 1 year ago

Regression Steps

From PR looks good

  1. From Global create, select Split Bill
  2. Go through the flow until the confirmation page
  3. click on the user details (do not create the split)
  4. Click Back (UP action) in left top corner of RHP
  5. Verify the screen navigated back to the confirmation page

👍 or 👎

melvin-bot[bot] commented 1 year ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.38-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-07-17. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

melvin-bot[bot] commented 1 year ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

mountiny commented 1 year ago

Reassinging the Bug label to get someone to pay this out

@Santhosh-Sellavel should get $1250 for the review and reporting the bug

Santhosh-Sellavel commented 1 year ago

Requested payment on ND

tjferriss commented 1 year ago

@Santhosh-Sellavel have you been paid via NewDot?

Santhosh-Sellavel commented 1 year ago

Yeah got paid! Good to close this!

melvin-bot[bot] commented 1 year ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.