[HOLD for payment 2023-10-05] Report - The request money is broken for "unknown" accounts without login information

lanitochka17 commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/22188

Action Performed:

Log in to the Expensify App with a GMAIL account
Tap a user you want to chat with from the list
Tap the "+" icon from the composer
Tap "Request money"
Enter the amount and tap next
Tap the "Request" green button
Tap the user you made an IOU with

Expected Result:

The IOU report page should not be grayed out and the composer should not be hidden for Gmail accounts

Actual Result:

The IOU report page is grayed out and the composer is hidden for Gmail accounts

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[ ] Android / Chrome
[x] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.38.3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/78819774/50d2d64a-ea07-4a92-85c6-adc5e7422fb3

Production IOS

https://github.com/Expensify/App/assets/78819774/e6bc8e54-bfcf-4fb5-83fc-741c14efd602

Staging IOS

https://github.com/Expensify/App/assets/78819774/ec7766e8-3913-4247-804e-04ccf1573ac5

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

aldo-expensify commented 1 year ago

Auth PR was deployed, removed HOLD from Web-E PR

aldo-expensify commented 1 year ago

Web-E PR merged: https://github.com/Expensify/Web-Expensify/pull/38236 Waiting for deploy to make App PR ready

melvin-bot[bot] commented 1 year ago

@aldo-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

aldo-expensify commented 1 year ago

The Web-E PR was deployed to staging, I'll make the App PR ready for review

aldo-expensify commented 1 year ago

Made PR ready for review

melvin-bot[bot] commented 1 year ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 year ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.74-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/23225

If no regressions arise, payment will be issued on 2023-10-05. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty