Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.36k stars 2.79k forks source link

IOU - Money Request and Split bill missing from LNH #22924

Closed lanitochka17 closed 1 year ago

lanitochka17 commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Preconditions: Must be logged in with the account workprofiletestuser@gmail.com Steps:

  1. Open https://staging.new.expensify.com/
  2. Click on the "Global action" button (Big green plus button in LHN)
  3. Click on "Request money"
  4. In the right column, enter any amount
  5. Click on the "Next" button
  6. In the search bar, type workprofiletestuser+5@gmail.com
  7. Click the "Request {Currency}{Quantity}" button
  8. Click on the user name with the red circle in the LHN from step 6

Expected Result:

When a user commits an IOU and sends another user request money, split bill, then an IOU should appear in LNH with that user

Actual Result:

When a user commits an IOU and sends another user request money, split bill, the IOU appears grayed out in LNH and when clicked it disappears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.41.1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/78819774/335a8734-6e5f-4830-ae44-0d436541f5ab

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

OSBotify commented 1 year ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

cead22 commented 1 year ago

Following the steps here worked for me. It looks like this request may have failed for @lanitochka17, I'm gonna see if I can find logs

image
mountiny commented 1 year ago

Looking at the logs we get 406 Chat report with these participants already exists with different ID

Hence I believe this is the same instance of https://github.com/Expensify/App/issues/22663 where the issue is stemming from the fact the other user is not knownUser and hence we dont retrieve the login field for them, which is needed to find the correct chat/ or pass the correct email to the command.

I dont think this should be a deploy blocker but its something we have to resolve after the secure login migration as there is no clear plan ahead afaik. Alex B is ooo today and Puneet is out for a week so we should probs discuss tomorrow

cead22 commented 1 year ago

Preconditions: Must be logged in with the account workprofiletestuser@gmail.com

I missed this, but now I'm able to reproduce, and I think I found a relevant error in the logs

Throwing exception with message: '406 Chat report with these participants already exists with different ID' from auth/lib/Transaction.cpp:1638 Error processing command 'CreateIOUTransaction' (406 Chat report with these participants already exists with different ID), ignoring.

cead22 commented 1 year ago

I reproduced the error in production (logs), so I don't think we need to block on this, since it also fails, even though it looks a little different

cead22 commented 1 year ago

Closing since this is kind of a duplicate of https://github.com/Expensify/App/issues/16105#issuecomment-1582359673 and https://github.com/Expensify/App/issues/22663 and it should be fixed by the same fix that addresses those