[HOLD for payment 2023-10-02] [$1000] Split Bill - After splitting money, clicking on IOU detail takes the user to the Concierge chat.

kbecciv commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to Website
Split bill.
Click on You preview.

Expected Result:

It should navigates user to you detail page.

Actual Result:

After splitting money, clicking on IOU detail takes the user to the Concierge chat.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.41-1 Reproducible in staging?: n/a Reproducible in production?: n/a If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/8fbf82ef-bee1-4294-a27a-45d87fc9e65d

Expensify/Expensify Issue URL: Issue reported by: @Ad-eeb Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689369192363999

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01fccec540368136b1
Upwork Job ID: 1681722206099353600
Automatic offers:

| | 0
| | 0

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

daordonez11 commented 1 year ago

Was analyzing to give a proposal but this is a regression of https://github.com/Expensify/App/pull/22787, which should be fixed as part of the original PR.

PS real steps, you need to get the issue of: There is a previously existing chat between these users, json code 666 in the command SplitBillAndOpenReport.

Expected behavior: should show the optimistic report or hmmm not here page.

cc @allroundexperts @wildan-m

allroundexperts commented 1 year ago

Thanks for letting us know @daordonez11!

@wildan-m, can you please confirm and possibly raise a fix PR?

wildan-m commented 1 year ago

@daordonez11 @allroundexperts thanks for the report, checking...

melvin-bot[bot] commented 1 year ago

Job added to Upwork: https://www.upwork.com/jobs/~01fccec540368136b1

melvin-bot[bot] commented 1 year ago

Current assignee @muttmuure is eligible for the External assigner, not assigning anyone new.

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

muttmuure commented 1 year ago

Reproduced, although I've just spotted that this is a regression so will double check if it should get a bounty

allroundexperts commented 1 year ago

This is a regression @muttmuure. Working on the review of the PR!

wildan-m commented 1 year ago

@allroundexperts any feedback on this fix PR?

allroundexperts commented 1 year ago

@allroundexperts any feedback on this fix PR?

Still testing it. Will test more tomorrow.

robertKozik commented 1 year ago

@muttmuure could you assign this issue to @allroundexperts as he is responsible for checking the PR for this regression?

allroundexperts commented 1 year ago

PS real steps, you need to get the issue of: There is a previously existing chat between these users, json code 666 in the command SplitBillAndOpenReport.

@daordonez11 I think these steps are different from what this issue is. With these steps, currently (without the changes of the PR mentioned), we're showing the user a 404 page which is incorrect as well. After applying the changes, the user is being redirected to concierge. I think both behaviours are incorrect. What should really happen in this case is that the backend should not clear the whole Onyx report. Rather it should just add error fields to the report object. That way, we can show to the user that some error occured.

melvin-bot[bot] commented 1 year ago

@muttmuure, @robertKozik Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 1 year ago

📣 @allroundexperts Please request via NewDot manual requests for the Contributor role ($1000)

melvin-bot[bot] commented 1 year ago

📣 @Ad-eeb We're missing your Upwork ID to automatically send you an offer for the Reporter role. Once you apply to the Upwork job, your Upwork ID will be stored and you will be automatically hired for future jobs!

muttmuure commented 1 year ago

Not overdue

melvin-bot[bot] commented 1 year ago

@allroundexperts @muttmuure this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 1 year ago

@allroundexperts, @muttmuure Huh... This is 4 days overdue. Who can take care of this?

muttmuure commented 1 year ago

Bumped @allroundexperts in Slack

muttmuure commented 1 year ago

being worked on over here: https://github.com/Expensify/App/issues/21518#issuecomment-1659525004

melvin-bot[bot] commented 1 year ago

@allroundexperts, @muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] commented 1 year ago

@allroundexperts @muttmuure this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

melvin-bot[bot] commented 1 year ago

@allroundexperts, @muttmuure Still overdue 6 days?! Let's take care of this!

muttmuure commented 1 year ago

Being discussed as an internal issue: https://github.com/Expensify/App/issues/21518#issuecomment-1670066169

melvin-bot[bot] commented 1 year ago

This issue has not been updated in over 15 days. @allroundexperts, @muttmuure eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

luacmartins commented 1 year ago

Assigning myself since this PR might fix this issue.

melvin-bot[bot] commented 1 year ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 year ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.73-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/24407

If no regressions arise, payment will be issued on 2023-10-02. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@allroundexperts does not require payment (Eligible for Manual Requests)
@Ad-eeb requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot[bot] commented 1 year ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@allroundexperts] Determine if we should create a regression test for this bug.
[ ] [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot[bot] commented 12 months ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

muttmuure commented 12 months ago

Looks like we don't think the other issue is a regression but I am going to keep an eye on it

muttmuure commented 12 months ago

Payment should be on 10-12

muttmuure commented 11 months ago

Ah, OK I miscalculated the dates and this can be paid out

muttmuure commented 11 months ago

Is this really linked to a deploy blocker? @luacmartins, @allroundexperts do you know?

luacmartins commented 11 months ago

AFAIK this was a regression of https://github.com/Expensify/App/pull/22787 (within the regression period) and fixed in https://github.com/Expensify/App/pull/24407

muttmuure commented 11 months ago

Clarifying here: https://expensify.slack.com/archives/C01SKUP7QR0/p1696923274741239

muttmuure commented 11 months ago

Going to close as this was a fix to a regression, which are not compensated

Ad-eeb commented 11 months ago

@muttmuure As far as I know, we pay for reporting regressions. I am not sure if something has changed. Can you share the link to the announcement if it has been changed?

muttmuure commented 11 months ago

You should be compensated

luacmartins commented 11 months ago

Just pending payment

luacmartins commented 11 months ago

Same as above. Still waiting on payment.

muttmuure commented 11 months ago

Handling

muttmuure commented 11 months ago

invite sent

muttmuure commented 11 months ago

Offer sent

muttmuure commented 11 months ago

Paid

Expensify / App